GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve hover color behavior for selectors by almarklein · Pull Request #799 · fastplotlib/fastplotlib

Conversation

@almarklein

@almarklein almarklein commented Apr 15, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Ref #781

I noticed that the color of the selector was flickering during motion, as the mouse enters and exits the object. This PR freezes the color while ._moving, keeping track of color changes in a dict, and then applying that dict when the moving is done.

Notice how the corner vertex becomes highlighted as the mouse is released after dragging the edge:

Screen.Recording.2025-04-15.at.11.29.22.mov

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@almarklein
Improve hover color behavior
e8a8f57
@almarklein
almarklein requested review from clewis7 and kushalkolar as code owners April 15, 2025 09:31
@almarklein
black
73afb85
@github-actions

github-actions Bot commented Apr 15, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/selector-color
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@almarklein almarklein changed the title Improve hover color behavior Improve hover color behavior for selectors Apr 15, 2025
kushalkolar
kushalkolar approved these changes Apr 15, 2025
View reviewed changes
@kushalkolar

kushalkolar commented Apr 15, 2025

Copy link
Copy Markdown
Member

Thanks! I also want to refactor it to use the SelectorColorStates later
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
kushalkolar merged commit 5e910cc into main Apr 15, 2025
@kushalkolar
kushalkolar deleted the selector-color branch April 15, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar approved these changes
@clewis7 clewis7 Awaiting requested review from clewis7 clewis7 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@almarklein @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.