GeezerVison is showing github.com — Fixes array issue that was causing incompatibility in the subsample a… by apasarkar · Pull Request #803 · fastplotlib/fastplotlib
Conversation
apasarkar
commented
Apr 18, 2025
•
edited by kushalkolar
Loading
Uh oh!
There was an error while loading. Please reload this page.
Small change, allows lazy arrays to pass as expected through the subsample (and the vmin/vmax quick computation) functions. Fixes #804
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…rray function for lazy array classes
|
Ah this is because whatever np.nanmin calls isn't implemented for your lazy arrays. If you have a way to pre-compute the min and max for your lazy arrays that would be fastest.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
clewis7
Awaiting requested review from clewis7
clewis7 is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Unexpected subsample_array behavior
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.