GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix rect manager by kushalkolar · Pull Request #820 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented May 15, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

#740 introduced bugs when imgui windows are added to the left or top edge of a figure. Got it working for grid layout. Need to get it working for the windowed layouts and setting from extents, add tests.

This was getting too complicated, for now just allow edgewindows to be added to the right or bottom edge.

This PR also adds a new example

funcs-2025-05-15_23.49.03.mp4

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kushalkolar added 4 commits May 15, 2025 00:09
@kushalkolar
bugfix imgui right click menu
494f657
@kushalkolar
almost fixed rect manager
841a9f1
@kushalkolar
revert, just disallow left and top edges for now
253afeb
@kushalkolar
cleanup docs guide
429decd
@kushalkolar
kushalkolar marked this pull request as ready for review May 16, 2025 03:55
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner May 16, 2025 03:55
@kushalkolar
remove file, fix
de02acb
@github-actions

github-actions Bot commented May 16, 2025

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/fix-rect-manager
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented May 16, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@clewis7 ready for review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 approved these changes May 19, 2025
View reviewed changes

@clewis7 clewis7 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@clewis7
clewis7 merged commit 54deeaf into main May 19, 2025
@clewis7
clewis7 deleted the fix-rect-manager branch May 19, 2025 17:59
@kushalkolar kushalkolar mentioned this pull request May 29, 2025
EdgeWindow locations bug #819
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.