GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docstring and docs cleanup, other misc small things by kushalkolar · Pull Request #828 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented May 19, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Renamed lots of instances where gridplot was still lingering to Figure. There is no such thing as "grid plot" anymore so changed those descriptions to "grid layout".

Some other docstring cleanup, reword some things to be better. Some better error messages in Figure.__init__()

removed "padding" kwarg for add_linear_selector() methods since it's no longer required since we have inf lines 😄

also fixes #818

@clewis7 ready for review

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kushalkolar added 12 commits May 19, 2025 02:51
@kushalkolar
rename cleanup, docstring cleanup
e098c38
@kushalkolar
docstring cleanup
70d4c00
@kushalkolar
docstrings
9f0de63
@kushalkolar
more docstring
52c62cb
@kushalkolar
docstring
3d12f6b
@kushalkolar
image docstrings
3da5abf
@kushalkolar
scatter docstrings
cfbde4b
@kushalkolar
rename
e24fba8
@kushalkolar
text docstrings
8d19386
@kushalkolar
yet more docstrings
42a6abf
@kushalkolar
another gridplot rename
11e8e00
@kushalkolar
better Figure names handling
1792811
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner May 19, 2025 07:40
kushalkolar added 3 commits May 19, 2025 03:56
@kushalkolar
properly remove padding kwarg
f1f5911
@kushalkolar
update quickstart.ipynb
d2d0aa3
@kushalkolar
black
6453b59
@kushalkolar kushalkolar changed the title docstring and docs cleanup docstring and docs cleanup, other misc small things May 19, 2025
clewis7
clewis7 requested changes May 19, 2025
View reviewed changes

@clewis7 clewis7 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor tweaks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread fastplotlib/graphics/image.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread fastplotlib/graphics/image.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread fastplotlib/graphics/line.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread fastplotlib/graphics/text.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread fastplotlib/graphics/text.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread fastplotlib/graphics/text.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread fastplotlib/graphics/text.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread fastplotlib/graphics/text.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar and others added 2 commits May 19, 2025 17:03
@kushalkolar @clewis7
Update fastplotlib/graphics/image.py
48e324b 
Co-authored-by: Caitlin Lewis <[email protected]>
@kushalkolar @clewis7
Apply suggestions from code review
fc5c577 
Co-authored-by: Caitlin Lewis <[email protected]>
@kushalkolar

kushalkolar commented May 19, 2025

Copy link
Copy Markdown
Member Author

I'm going to add a test for figure name stuff
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar added 6 commits May 19, 2025 20:21
@kushalkolar
better names logic
8e00fa1
@kushalkolar
Merge branch 'old-renames' of https://github.com/fastplotlib/fastplotlib
fef5c50 
 into old-renames
@kushalkolar
update example
a3f6181
@kushalkolar
sphinx is annoying
bce7efc
@kushalkolar
update add_graphic methods mixin
3db29c2
@kushalkolar
update generate script
79fcbd5
@github-actions

github-actions Bot commented May 20, 2025

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/old-renames
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented May 20, 2025

Copy link
Copy Markdown
Member Author

@clewis7 ready for another look, better logic to check subplot_names size, tests for it, and updated add_ methods mixin
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 approved these changes May 20, 2025
View reviewed changes
@clewis7
clewis7 merged commit 0de38a7 into main May 20, 2025
@clewis7
clewis7 deleted the old-renames branch May 20, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ImageWidget with 3+ subplots requires figure_shape

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.