GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||
GeezerVison is showing github.com — Tweaks to adjust to new pygfx blending by almarklein · Pull Request #838 · fastplotlib/fastplotlib Conversation
Collaborator
For upcoming pygfx/pygfx#1002 May not be complete, can leave open until the pygfx-pr is merged.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
kushalkolar
reviewed
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what about the overlay?
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point, you may want to use a different depth range in the camera, so that the fragments all have a very small depth value, so they don't get behind stuff in the scene. Or simply disable depth-tests.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
|
I think this should be merged soon after we decide how to deal with the depth buffer for the overlay pass? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
There are some more upcoming changes. I'll likely make some more changes this week. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Let's merge this, so we keep |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Failures are due to pygfx/wgpu-py#723 And I think due to AA being disabled for tests now? Some diffs below: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
The image tests fail because the downsample filter is changed (to go from hirez to target rez). So indeed related to SSAA. See pygfx/pygfx#1121 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
The env var that disables PPAA is for a different kind of aa 😉, which has not been merged yet (at the time of writing): pygfx/pygfx#1117 That env var will make sure that the screenshots don't change when that PR is in effect. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/pygfx-blending |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
So if I update the ground truth screenshots good to go!? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I'm half wondering if I want to add a similar env var to override the pixel_ratio for screenshot tests, now that we have to update all screenshots ... I'm sorry it takes so long. Is this stopping other prs from progressing? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
EDIT: ok now I understand how github actions pushes generated screenshots artifacts. If an image hasn't been re-generated it still gets sent because it exists in the repo already. I should do separate dirs for imgui and non-imgui screenshots or filter what's upload to the artifact. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
merging, now main requires pygfx@main too
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.