GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — `@Figure.add_gui` and `append_gui` decorators by kushalkolar · Pull Request #849 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Jun 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

closes #848

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kushalkolar
basic prototype working :D
18383fc
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner June 1, 2025 00:20
kushalkolar added 7 commits June 1, 2025 00:21
@kushalkolar
add ChangeFlag
8214849
@kushalkolar
docstring, comments
3c998ee
@kushalkolar
fix
eae0fa0
@kushalkolar
fig as argument to add_gui() decorated function, comments
832f6fd
@kushalkolar
update basic example to use changeflag
c7b92e1
@kushalkolar
add figure.remove_gui(), better handling in add_gui
15baeb7
@kushalkolar
bugfix
3a93189
clewis7
clewis7 reviewed Jun 2, 2025
View reviewed changes
Comment thread examples/guis/imgui_decorator.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@clewis7

clewis7 commented Jun 2, 2025

Copy link
Copy Markdown
Member

I have never seen someone love a decorator more than you lol

FlynnOConnell reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@clewis7

clewis7 commented Jun 2, 2025

Copy link
Copy Markdown
Member

I think this is pretty cool

One thing, I'm not sure how I feel about the ChangeFlag class

It seems like a lot of scaffolding just to indicate that the user has interacted with the imgui window...unless I am missing something

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar

kushalkolar commented Jun 2, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

One thing, I'm not sure how I feel about the ChangeFlag class

It seems like a lot of scaffolding just to indicate that the user has interacted with the imgui window...unless I am missing something

It's useful when you have a lot of UI elements that could have changed and you want to know if any of them have changed. It's cumbersome to write:

changed1, val1 = imgui.slider(...)
changed2, val2 = imgui.slider(...)
...
changed_n, valn = imgui.slider(...)

if any([changed1, changed2, ... change_d]):
  # recompute

# could also do
if changed1 | changed2 | ... changed_n:
  # recompute

Basically the following is invalid python syntax otherwise I would just use the or operator | with tuple unpacking:

changed |, val1 = imgui.slider(...)
changed |, val2 = imgui.slider(...)
...
changed |, val_n = imgui.slider(...)

This is valid without tuple unpacking:

changed = func()
changed |= func2()
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar kushalkolar mentioned this pull request Jun 5, 2025
add ImageVolumeGraphic #791
Merged
14 tasks done
kushalkolar added 2 commits June 29, 2025 01:30
@kushalkolar
@Figure.append_gui decorator
6905335
@kushalkolar
docstring
b3dda82
@kushalkolar kushalkolar changed the title more imgui stuff! @Figure.add_gui and append_gui decorators Jun 29, 2025
@kushalkolar

kushalkolar commented Jun 29, 2025

Copy link
Copy Markdown
Member Author

Failures are due to an imgui update

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@FlynnOConnell FlynnOConnell mentioned this pull request Nov 23, 2025
add imgui file dialog example #950
Open
@kushalkolar kushalkolar mentioned this pull request May 9, 2026
Bunch of minor improvements to prioritize #1048
Open
@kushalkolar

kushalkolar commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

superseeded by #1066

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar kushalkolar closed this Aug 4, 2026
@kushalkolar
kushalkolar deleted the imgui-decs branch August 4, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create imgui edge windows without declaring a class

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.