GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix move to pointer for linear and linear region selector by kushalkolar · Pull Request #855 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Jun 6, 2025

Copy link
Copy Markdown
Member

fixes the move_to_pointer upon middle mouse click for linear and linear region selectors.

also uses the passed move_info for the move_graphic methods, @almarklein does this look good to you?

closes #854

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
fix move to pointer for liner and linear region selctor
acfa197
@kushalkolar
kushalkolar requested a review from almarklein June 6, 2025 05:25
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner June 6, 2025 05:25
@kushalkolar kushalkolar changed the title fix move to pointer for liner and linear region selctor fix move to pointer for linear and linear region selctor Jun 6, 2025
@kushalkolar kushalkolar changed the title fix move to pointer for linear and linear region selctor fix move to pointer for linear and linear region selector Jun 6, 2025
@github-actions

github-actions Bot commented Jun 6, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/fix-selectors
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
almarklein
almarklein previously approved these changes Jun 6, 2025
View reviewed changes
Comment thread fastplotlib/graphics/selectors/_base_selector.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar
kushalkolar commented Jun 11, 2025
View reviewed changes
Comment thread fastplotlib/graphics/selectors/_base_selector.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
Update fastplotlib/graphics/selectors/_base_selector.py
fcfe16a
@kushalkolar
kushalkolar dismissed almarklein’s stale review via fcfe16a June 11, 2025 08:19
@kushalkolar

kushalkolar commented Jun 11, 2025

Copy link
Copy Markdown
Member Author

@clewis7 should be gtg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 approved these changes Jun 11, 2025
View reviewed changes
@clewis7
clewis7 merged commit 72a3f02 into main Jun 11, 2025
@clewis7
clewis7 deleted the fix-selectors branch June 11, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes
@almarklein almarklein almarklein left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

move to pointer on mouse middle click is broken for selectors

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kushalkolar @almarklein @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.