GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — remove existing screenshots in regenerate action by kushalkolar · Pull Request #915 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Oct 11, 2025

Copy link
Copy Markdown
Member

closes #912

@almarklein I think this will fix it right?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
remove existing screenshots in regenerate action
70302cf
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner October 11, 2025 00:32
@github-actions

github-actions Bot commented Oct 11, 2025

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/remove-existing-screenshots
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Oct 11, 2025

Copy link
Copy Markdown
Member Author

yup this works! Now there are no no-imgui screenshots in the non-imgui regeneration artifact 😆 . And only the standard with imgui screenshots in the imgui regeneration artifact.

@clewis7 should be gtg, tests will not pass because a few PRs have to be merged/have been merged that change most screenshots so I'll do it all at once.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Oct 11, 2025

Copy link
Copy Markdown
Member Author

@clewis7 let's merge this first and then I can rebase #914 on main so it has the nice cleaner screenshots artifact, and I will replace the screenshots on that PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@almarklein

almarklein commented Oct 11, 2025

Copy link
Copy Markdown
Collaborator

Thanks for solving this 😃
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 approved these changes Oct 17, 2025
View reviewed changes
@clewis7
clewis7 merged commit 31f0f03 into main Oct 17, 2025
@clewis7
clewis7 deleted the remove-existing-screenshots branch October 17, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

screenshot artifacts

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kushalkolar @almarklein @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.