GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — skip existing arrays in ImageWidget.set_data() by kushalkolar · Pull Request #924 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Oct 20, 2025

Copy link
Copy Markdown
Member

Skips data arrays that already exist, closes #901

@clewis7 should be gtg

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kushalkolar
skip existing arrays in ImageWidget.set_data()
4eaf110
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner October 20, 2025 22:59
@github-actions

github-actions Bot commented Oct 20, 2025

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/iw-set-data-subset2

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

clewis7
clewis7 approved these changes Oct 21, 2025
View reviewed changes

@clewis7 clewis7 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool! I didn't know you could do this kind of comparison without np.all()

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@clewis7
clewis7 merged commit 522c296 into main Oct 21, 2025
@clewis7
clewis7 deleted the iw-set-data-subset2 branch October 21, 2025 12:43
@kushalkolar

kushalkolar commented Oct 21, 2025

Copy link
Copy Markdown
Member Author

This is cool! I didn't know you could do this kind of comparison without np.all()

This is only checking that the object reference is the same. If "new_data" is an array with the same values as the existing data array then it won't pass this check.

Intended use is something like this:

a, b, c, d # existing arrays

iw = fpl.ImageWidget([a, b, c, d])

# I want to replace only c

new = np.array(...)

iw.set_data([a, b, new, d])

# this will also end up replacing

a_copy = a.copy()

iw.set_data([a_copy, b, c, d])
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ImageWidget.set_data() for a subset of the data arrays

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.