GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — better plot scaling logic by kushalkolar · Pull Request #938 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Nov 12, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

When one controller manages multiple cameras in a Figure, i.e. when multiple subplot all share a controller, the current implementation of auto_center() and auto_scale() sets the cameras of those other subplots based on the bounding box of the scene in the current subplot. This is a problem when the scales are very different between subplots!

This PR now sets the cameras of the other subplots based on the other subplot's own scene bbox.

closes #783 , closes #821

Example with the same code from #783

Notice how the y-scales are very different.

sync.x-2025-11-12_03.18.14.mp4

@clewis7 can we get this merged ASAP please 😄

This shouldn't break any existing functionality, the screenshot tests will tell.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
better plot scaling logic for when a subplot controller manages multi…
4a0cbcb 
…ple cameras
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner November 12, 2025 08:20
@kushalkolar
skip scaling in empty subplots
ac16a8f
@kushalkolar

kushalkolar commented Nov 12, 2025

Copy link
Copy Markdown
Member Author

@almarklein getting large diffs with colors across the entire canvas, did something change recently?

Regenerate is producing nans for some images so I'm guessing the image saving lib change something recently: https://github.com/fastplotlib/fastplotlib/actions/runs/19291516914/job/55163104901?pr=938#step:8:1528

diff-image_simple-rgb diff-image_rgb-rgb diff-image_volume_non_orthogonal_slicing-rgb diff-line_cmap-rgb diff-line_collection_cmap_values_qualitative-rgb diff-scatter_validate-rgb
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@almarklein

almarklein commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

Could you try pinning pygfx==0.15.2 in pyproject.toml?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@almarklein

almarklein commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

But still, it also happens for main. And only for Python 3.13??
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar kushalkolar mentioned this pull request Nov 14, 2025
API for customizable camera linking of individual axes #941
Open
@kushalkolar

kushalkolar commented Nov 14, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@clewis7 can merge #939 and then merge main into this and hopefully tests pass.

I want to make some examples for this and we can brainstorm how to make this more easily accessible in the API but let's do that later, I made #941 for that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
Merge branch 'main' into better-plot-scaling
6562adf
@github-actions

github-actions Bot commented Nov 15, 2025

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/better-plot-scaling
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Nov 15, 2025

Copy link
Copy Markdown
Member Author

@clewis7 gtg!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 approved these changes Nov 15, 2025
View reviewed changes
@clewis7
clewis7 merged commit c924c66 into main Nov 15, 2025
36 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@clewis7
clewis7 deleted the better-plot-scaling branch November 15, 2025 14:25
@kushalkolar kushalkolar mentioned this pull request Mar 20, 2026
add partial camera linking example #1020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Share axes between subplots Customizable camera linking does not work

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kushalkolar @almarklein @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.