GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — remove dim length checks in `iw.set_data()` by kushalkolar · Pull Request #965 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Dec 16, 2025

Copy link
Copy Markdown
Member

I don't think this check is actually necessary. Kinda need it now for an IBL prototype. #951 will replace it soon anyways.

@clewis7 should be gtg if tests pass

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
remove dim length checks in iw.set_data()
536b4ce
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner December 16, 2025 06:48
@github-actions

github-actions Bot commented Dec 16, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/iw-remove-dim-check
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 previously approved these changes Dec 16, 2025
View reviewed changes
@clewis7

clewis7 commented Dec 16, 2025

Copy link
Copy Markdown
Member

Can you lint and then I will merge?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
black
0e75897
@kushalkolar
kushalkolar dismissed clewis7’s stale review via 0e75897 December 16, 2025 21:41
clewis7
clewis7 approved these changes Dec 17, 2025
View reviewed changes
@clewis7
clewis7 merged commit 68dceee into main Dec 17, 2025
36 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@clewis7
clewis7 deleted the iw-remove-dim-check branch December 17, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.