GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Adding top gui to fpl by clewis7 · Pull Request #999 · fastplotlib/fastplotlib

Conversation

@clewis7

@clewis7 clewis7 commented Feb 20, 2026

Copy link
Copy Markdown
Member
image

I thought this would follow the patterns of the other guis (just change the y pos of where pygfx renders to), but the render space does not actually move down unless I manually set the rect

Maybe that is not something that needs to be done for bottom and right but does for a left or top gui

Have enough for the thing I need to do for clepio and can circle back to this

@kushalkolar thoughts welcome since you did the frame/rect manager stuff

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@clewis7
top gui
0f0feac
@clewis7
clewis7 requested a review from kushalkolar as a code owner February 20, 2026 02:05
@clewis7
clewis7 marked this pull request as draft February 20, 2026 02:05
@kushalkolar

kushalkolar commented Feb 20, 2026

Copy link
Copy Markdown
Member

I'm brain fried I'll review tomorrow or this weekend, but if right and bottom imgui windows still work then it's probably fine, let's worry about left guis when there's a compelling use case?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar
kushalkolar reviewed Feb 20, 2026
View reviewed changes
Comment thread examples/guis/imgui_top.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

clewis7 added 2 commits February 19, 2026 23:06
@clewis7
fix
55c9ba4
@clewis7
proper logic
95ba75a
@clewis7

clewis7 commented Feb 20, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Proper logic for setting the pyfgx render space and allowing space for guis is in _imgui_figure.py and ui/_base.py

The issue now is getting the rect manager and frame to obey the change in the y-coord

image

The height is changing appropriately but the y-coord to start rendering from is not being obeyed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@clewis7

clewis7 commented Feb 20, 2026

Copy link
Copy Markdown
Member Author

Okay, the reason that it is not shifting down is because updates to the layout use the fractional layout to resize, and the rect manager does not take into account x or y offset when doing this

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

clewis7 added 2 commits February 20, 2026 15:54
@clewis7
allow for y and x offset scaling
3267832
@clewis7
also fix for setting by pixel
a69de43
@clewis7
clewis7 marked this pull request as ready for review February 20, 2026 21:28
@github-actions

github-actions Bot commented Feb 20, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/top-gui

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@clewis7
add screenshot
18fdc97
@clewis7

clewis7 commented Feb 22, 2026

Copy link
Copy Markdown
Member Author

@kushalkolar gtg if you can give a review!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar
kushalkolar requested changes Feb 23, 2026
View reviewed changes

@kushalkolar kushalkolar left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small things

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread fastplotlib/layouts/_imgui_figure.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread fastplotlib/layouts/_frame.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread fastplotlib/layouts/_rect.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread fastplotlib/layouts/_rect.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread fastplotlib/layouts/_rect.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar

kushalkolar commented Feb 23, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Tested that the window layouts subplots move and resize properly with these changes? We can make automated tests for that later.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@clewis7
small fixes
9e4010e
@clewis7

clewis7 commented Feb 23, 2026

Copy link
Copy Markdown
Member Author

Tested that the window layouts subplots move and resize properly with these changes? We can make automated tests for that later.

I tested locally that the window layout examples are still working (resizing and moving subplots around)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@clewis7

clewis7 commented Feb 23, 2026

Copy link
Copy Markdown
Member Author
image

Since I didn't post what it looked like after the changes

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar
kushalkolar approved these changes Feb 23, 2026
View reviewed changes
@kushalkolar
kushalkolar merged commit 9a8a1b8 into main Feb 23, 2026
38 of 52 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar
kushalkolar deleted the top-gui branch February 23, 2026 18:05
@kushalkolar

kushalkolar commented Mar 4, 2026

Copy link
Copy Markdown
Member

The example png file got committed directly to git instead of git lfs, no idea why 🤦‍♂️ . I wonder if there's CI action we can use to catch this in the future. Since this was a recent commit to main I think we can undo it without too much trouble.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@clewis7

clewis7 commented Mar 4, 2026

Copy link
Copy Markdown
Member Author

🤦

Wow that is totally my fault

I can open a PR to fix today. I need to go in and fix the contrib docs so that they are a little clearer on the screenshot uploads.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar

kushalkolar commented Mar 4, 2026

Copy link
Copy Markdown
Member

It shouldn't be possible, seems git just ignored the .gitattributes for some reason

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@clewis7 @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.