GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — Adding top gui to fpl by clewis7 · Pull Request #999 · fastplotlib/fastplotlib Conversation
Member
I thought this would follow the patterns of the other guis (just change the y pos of where pygfx renders to), but the render space does not actually move down unless I manually set the rect Maybe that is not something that needs to be done for bottom and right but does for a left or top gui Have enough for the thing I need to do for clepio and can circle back to this @kushalkolar thoughts welcome since you did the frame/rect manager stuff
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
clewis7
marked this pull request as draft
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
kushalkolar
reviewed
Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
Okay, the reason that it is not shifting down is because updates to the layout use the fractional layout to resize, and the rect manager does not take into account x or y offset when doing this |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/top-gui |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@kushalkolar gtg if you can give a review! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
small things
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Tested that the window layouts subplots move and resize properly with these changes? We can make automated tests for that later. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I tested locally that the window layout examples are still working (resizing and moving subplots around) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
The example png file got committed directly to git instead of git lfs, no idea why 🤦♂️ . I wonder if there's CI action we can use to catch this in the future. Since this was a recent commit to main I think we can undo it without too much trouble. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤦 Wow that is totally my fault I can open a PR to fix today. I need to go in and fix the contrib docs so that they are a little clearer on the screenshot uploads. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It shouldn't be possible, seems git just ignored the .gitattributes for some reason |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.