Description

arielj

opened on Jul 6, 2022

Issue body actions

This test https://github.com/fastruby/fast-ruby/blob/master/code/general/block-apply-method.rb is comparing:

def fast
  [1, 2, 3].map { |n| do_something(n) }
end

def slow
  [1, 2, 3].map(&method(:do_something))
end

We could have one more test:

def other
  [1, 2, 3].map(&:do_something)
end

Also, I think the names fast and slow shouldn't be used for the methods, the names should describe what the method does, not which one is faster?

Reacted by Juan Vásquez

Activity

1. ashwinisukale

   added

   Suggestion

   on Oct 11, 2022
2. ashwinisukale commented on Oct 11, 2022

   

   ashwinisukale

   on Oct 11, 2022

   More actions

   @arielj I guess name fast and slow just indicate which way is faster. In this case if we should not use &method because its slower.
3. JuanVqz

   self-assigned this

   on Sep 29, 2026
4. JuanVqz commented on Sep 29, 2026

   

   JuanVqz

   on Sep 29, 2026

   Member

   More actions

   Hey @arielj, I tried your suggested addition, but [1, 2, 3].map(&:do_something) calls n.do_something instead of do_something(n), so n never gets passed as the argument and Ruby raises:

     private method 'do_something' called for an instance of Integer (NoMethodError)
   

   Am I missing something? What did you have in mind for this case?

Issue actions