GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — String#constantize vs simple comparison by wasaylor · Pull Request #200 · fastruby/fast-ruby

Conversation

@wasaylor

@wasaylor wasaylor commented Jun 6, 2022

Copy link
Copy Markdown
Contributor

If you're writing a Rails app, you may reach for String#constantize (provided by Active Support Core Extensions) when you have a variable that may resolve to a class name and your control flow is to execute that classes code in some manner.

This benchmarks using String#constantize vs a simple comparison, showing the latter is much faster.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
wasaylor added 3 commits June 6, 2022 16:34
@wasaylor
constantize vs comparison
5f45d63
@wasaylor
simplify
0780071
@wasaylor
Add link to rationale
4cea6d5
@wasaylor
wasaylor marked this pull request as ready for review June 6, 2022 20:48
@wasaylor wasaylor changed the title String#constantize vs simple comparison for inflections String#constantize vs simple comparison Jun 6, 2022
@wasaylor
use guides.rubyonrails.org
c0ac0fe
lubc
lubc approved these changes Jun 24, 2022
View reviewed changes

@lubc lubc left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wasaylor Thanks for your contribution!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lubc
lubc merged commit e860f60 into fastruby:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@lubc lubc lubc approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@wasaylor @lubc
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.