GeezerVison is showing github.com — refactor: Use field numbers 36/37 for VALUE_LIST/VALUE_SET instead of… · feast-dev/feast@bf3b971
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: protos/feast/types/Value.proto +4-6Lines changed: 4 additions & 6 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -57,10 +57,8 @@ message ValueType { |
57 | 57 | JSON_LIST = 33; |
58 | 58 | STRUCT = 34; |
59 | 59 | STRUCT_LIST = 35; |
60 | | - // 36-39 were LIST_LIST, LIST_SET, SET_LIST, SET_SET (removed, replaced by VALUE_LIST/VALUE_SET) |
61 | | - reserved 36, 37, 38, 39; |
62 | | - VALUE_LIST = 40; |
63 | | - VALUE_SET = 41; |
| 60 | + VALUE_LIST = 36; |
| 61 | + VALUE_SET = 37; |
64 | 62 | } |
65 | 63 | } |
66 | 64 |
|
@@ -100,8 +98,8 @@ message Value { |
100 | 98 | StringList json_list_val = 33; |
101 | 99 | Map struct_val = 34; |
102 | 100 | MapList struct_list_val = 35; |
103 | | - RepeatedValue list_val = 40; |
104 | | - RepeatedValue set_val = 41; |
| 101 | + RepeatedValue list_val = 36; |
| 102 | + RepeatedValue set_val = 37; |
105 | 103 | } |
106 | 104 | } |
107 | 105 |
|
|
Collapse file
Copy file name to clipboardExpand all lines: sdk/python/feast/protos/feast/types/Value_pb2.py +43-43Lines changed: 43 additions & 43 deletions Collapse file
Copy file name to clipboardExpand all lines: sdk/python/feast/protos/feast/types/Value_pb2.pyi +4-4Lines changed: 4 additions & 4 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -86,8 +86,8 @@ class ValueType(google.protobuf.message.Message): |
86 | 86 | JSON_LIST: ValueType._Enum.ValueType # 33 |
87 | 87 | STRUCT: ValueType._Enum.ValueType # 34 |
88 | 88 | STRUCT_LIST: ValueType._Enum.ValueType # 35 |
89 | | - VALUE_LIST: ValueType._Enum.ValueType # 40 |
90 | | - VALUE_SET: ValueType._Enum.ValueType # 41 |
| 89 | + VALUE_LIST: ValueType._Enum.ValueType # 36 |
| 90 | + VALUE_SET: ValueType._Enum.ValueType # 37 |
91 | 91 |
|
92 | 92 | class Enum(_Enum, metaclass=_EnumEnumTypeWrapper): ... |
93 | 93 | INVALID: ValueType.Enum.ValueType # 0 |
@@ -122,8 +122,8 @@ class ValueType(google.protobuf.message.Message): |
122 | 122 | JSON_LIST: ValueType.Enum.ValueType # 33 |
123 | 123 | STRUCT: ValueType.Enum.ValueType # 34 |
124 | 124 | STRUCT_LIST: ValueType.Enum.ValueType # 35 |
125 | | - VALUE_LIST: ValueType.Enum.ValueType # 40 |
126 | | - VALUE_SET: ValueType.Enum.ValueType # 41 |
| 125 | + VALUE_LIST: ValueType.Enum.ValueType # 36 |
| 126 | + VALUE_SET: ValueType.Enum.ValueType # 37 |
127 | 127 |
|
128 | 128 | def __init__( |
129 | 129 | self, |
|
Collapse file
Copy file name to clipboardExpand all lines: sdk/python/feast/value_type.py +2-2Lines changed: 2 additions & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -71,8 +71,8 @@ class ValueType(enum.Enum): |
71 | 71 | JSON_LIST = 33 |
72 | 72 | STRUCT = 34 |
73 | 73 | STRUCT_LIST = 35 |
74 | | - VALUE_LIST = 40 |
75 | | - VALUE_SET = 41 |
| 74 | + VALUE_LIST = 36 |
| 75 | + VALUE_SET = 37 |
76 | 76 |
|
77 | 77 |
|
78 | 78 | ListType = Union[ |
|