GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Snowflake support does not include list features · Issue #2280 · feast-dev/feast

Snowflake support does not include list features #2280

New issue
Copy link
New issue
Copy link
Closed
#3769
Closed
Snowflake support does not include list features#2280
#3769
Copy link
Assignees
sfc-gh-madkins
Labels
Community Contribution NeededWe want community to contributeWe want community to contributekind/bugkind/featureNew feature or requestNew feature or requestpriority/p2

Description

@adchia
adchia
opened on Feb 3, 2022
Issue body actions

Expected Behavior

Snowflake offline store works with list features

Current Behavior

Right now Snowflake produces errors when using list features. This isn't caught by tests because of this skip with the aws provider: https://github.com/feast-dev/feast/blob/master/sdk/python/tests/integration/registration/test_universal_types.py#L39

Activity

Next
  1. adchia
    added
    kind/bug
    priority/p2
    on Feb 3, 2022
  2. github-actions
    assigned
    tsotnet
    on Feb 3, 2022
  3. adchia
    unassigned
    tsotnet
    on Feb 3, 2022
  4. adchia commented on Feb 3, 2022

    @adchia
    adchia
    on Feb 3, 2022
    CollaboratorAuthor
    More actions

    cc @sfc-gh-madkins

  5. sfc-gh-madkins commented on Feb 19, 2022

    @sfc-gh-madkins
    sfc-gh-madkins
    on Feb 19, 2022
    Collaborator
    More actions

    @adchia @woop here is the docs related to semi-structured data in Snowflake: https://docs.snowflake.com/en/sql-reference/data-types-semistructured.html#array

    Arrays for list feature types are possible in Snowflake, but there is no enforcement of data type within the array, its stored as type VARIANT, where VARIANT, can store values of any other type, including OBJECT and ARRAY, up to a maximum size of 16 MB. Snowflake does not currently support fixed-size arrays or arrays of elements of a specific non-VARIANT type.

    Im curious to your initial thoughts on this. We can certainly test an array if it complies with a certain data type that is supported or throw an error. If it does then execellent, if not we throw an error to remove the feature

  6. stale commented on Jun 19, 2022

    @stale
    staleBot
    on Jun 19, 2022
    More actions

    This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

  7. stale
    added
    wontfixThis will not be worked onThis will not be worked on
    on Jun 19, 2022
  8. stale
    closed this as completedon Jul 12, 2022
  9. achals
    reopened this on Jul 12, 2022
  10. achals commented on Jul 13, 2022

    @achals
    achals
    on Jul 13, 2022
    Member
    More actions

    I think we can take the approach described by @sfc-gh-madkins

  11. stale
    removed
    wontfixThis will not be worked onThis will not be worked on
    on Jul 13, 2022
  12. kevjumba
    added
    Community Contribution NeededWe want community to contributeWe want community to contribute
    on Aug 3, 2022
  13. sfc-gh-madkins
    self-assigned this
    on Aug 15, 2022
  14. sfc-gh-madkins
    removed
    kind/bug
    on Aug 17, 2022
  15. 4 remaining items

  16. sfc-gh-madkins commented on Dec 16, 2022

    @sfc-gh-madkins
    sfc-gh-madkins
    on Dec 16, 2022
    Collaborator
    More actions

    bump

    Reacted by William Ma
  17. stale
    removed
    wontfixThis will not be worked onThis will not be worked on
    on Dec 16, 2022
  18. stale commented on Apr 26, 2023

    @stale
    staleBot
    on Apr 26, 2023
    More actions

    This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

  19. stale
    added
    wontfixThis will not be worked onThis will not be worked on
    on Apr 26, 2023
  20. sfc-gh-madkins commented on Apr 26, 2023

    @sfc-gh-madkins
    sfc-gh-madkins
    on Apr 26, 2023 via email
    Collaborator
    More actions
    bump
    …
    On Tue, Apr 25, 2023 at 8:30 PM stale[bot] ***@***.***> wrote: This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. — Reply to this email directly, view it on GitHub <#2280 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATSRCU5DJDXD5YTTP23ET2LXDB3FFANCNFSM5NPKRUQQ> . You are receiving this because you were assigned.Message ID: ***@***.***>
  21. stale
    removed
    wontfixThis will not be worked onThis will not be worked on
    on Apr 26, 2023
  22. JohnLemmonMedely commented on Sep 5, 2023

    @JohnLemmonMedely
    JohnLemmonMedely
    on Sep 5, 2023
    Contributor
    More actions

    Looks like we'll need this for our implementation so I'll be taking a look at implementing this in our sprint starting tomorrow.

  23. sfc-gh-madkins commented on Sep 5, 2023

    @sfc-gh-madkins
    sfc-gh-madkins
    on Sep 5, 2023
    Collaborator
    More actions

    @JohnLemmonMedely I am afraid snowflake does not support structured types on the server side. All semistructured types are currently returns as strings. We are working to support this in the next couple of quarters.

  24. JohnLemmonMedely commented on Sep 5, 2023

    @JohnLemmonMedely
    JohnLemmonMedely
    on Sep 5, 2023
    Contributor
    More actions

    @sfc-gh-madkins I was planning on using the method you suggested earlier and attempt to cast them to what they need to be and throwing errors when we can't. It'll be better to guarantee data types via Snowflake but until that's possible I can enforce those guarantees myself via the data pipeline.

    We can certainly test an array if it complies with a certain data type that is supported or throw an error. If it does then execellent, if not we throw an error to remove the feature

  25. sfc-gh-madkins commented on Sep 5, 2023

    @sfc-gh-madkins
    sfc-gh-madkins
    on Sep 5, 2023 via email
    Collaborator
    More actions
    will look forward to the PR :)
    …
    On Tue, Sep 5, 2023 at 4:51 PM John Lemmon ***@***.***> wrote: @sfc-gh-madkins <https://github.com/sfc-gh-madkins> I was planning on using the method you suggested earlier and attempt to cast them to what they need to be and throwing errors when we can't. It'll be better to guarantee data types via Snowflake but until that's possible I can enforce those guarantees myself via the data pipeline. We can certainly test an array if it complies with a certain data type that is supported or throw an error. If it does then execellent, if not we throw an error to remove the feature — Reply to this email directly, view it on GitHub <#2280 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATSRCU3WGHHQXHAVBAE467LXY6NH7ANCNFSM5NPKRUQQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>
  26. JohnLemmonMedely commented on Dec 8, 2023

    @JohnLemmonMedely
    JohnLemmonMedely
    on Dec 8, 2023
    Contributor
    More actions

    @sfc-gh-madkins I had to pause my work on the PR but we were able to use my fork in production. I'm trying to see if it makes sense at this point to get the PR ready to merge or if I should just wait on Snowflake adding structured types instead. Is that still on the Roadmap to add early next year?

  27. sfc-gh-madkins commented on Dec 8, 2023

    @sfc-gh-madkins
    sfc-gh-madkins
    on Dec 8, 2023 via email
    Collaborator
    More actions
    let me ping to see where this is at
    …
    On Fri, Dec 8, 2023 at 11:41 AM John Lemmon ***@***.***> wrote: @sfc-gh-madkins <https://github.com/sfc-gh-madkins> I had to pause my work on the PR but we were able to use my fork in production. I'm trying to see if it makes sense at this point to get the PR ready to merge or if I should just wait on Snowflake adding structured types instead. Is that still on the Roadmap to add early next year? — Reply to this email directly, view it on GitHub <#2280 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATSRCU4FFUY62RAO4MRN3XTYINGNJAVCNFSM5NPKRUQ2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBUG42TOOBYGEYQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>
  28. JohnLemmonMedely commented on Dec 15, 2023

    @JohnLemmonMedely
    JohnLemmonMedely
    on Dec 15, 2023
    Contributor
    More actions

    @sfc-gh-madkins just following up on if Snowflake still plans on supporting structured types soon. I just need to know if work will start on it over the next quarter or not.

  29. sfc-gh-madkins commented on Dec 16, 2023

    @sfc-gh-madkins
    sfc-gh-madkins
    on Dec 16, 2023 via email
    Collaborator
    More actions
    negative. this is continuing to be pushed out due to lack of customer demand. however, we do now have vector support capabilities for both fixed and floating point 32 bit numbers, however, the client arent ready yet
    …
    On Fri, Dec 15, 2023 at 10:09 AM John Lemmon ***@***.***> wrote: @sfc-gh-madkins <https://github.com/sfc-gh-madkins> just following up on if Snowflake still plans on supporting structured types soon. I just need to know if work will start on it over the next quarter or not. — Reply to this email directly, view it on GitHub <#2280 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATSRCUZRMMJRFCX2LJLWSOLYJRY5JAVCNFSM5NPKRUQ2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBVHAYTEMRVHAZA> . You are receiving this because you were mentioned.Message ID: ***@***.***>
  30. etirelli
    closed this as completedin #3769on Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

  • @sfc-gh-madkins
    sfc-gh-madkins

Labels

Community Contribution NeededWe want community to contributeWe want community to contributekind/bugkind/featureNew feature or requestNew feature or requestpriority/p2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    You are visitor 01402503 — GeezerVison does not store the pages you look up.
    Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.