GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — data sources displayed different depending on "inline" definition · Issue #2991 · feast-dev/feast

data sources displayed different depending on "inline" definition #2991

New issue
Copy link
New issue
Copy link
Closed
#3036
Closed
data sources displayed different depending on "inline" definition#2991
#3036
Copy link
Assignees
felixwang9817
Labels
criticalkind/bugpriority/p2

Description

@cburroughs
cburroughs
opened on Aug 1, 2022
Issue body actions

Expected Behavior

Many of the docs define data sources "inline" from the feature view. For example https://docs.feast.dev/getting-started/concepts/feature-view

driver_stats_fv = FeatureView(
    #...
    source=BigQuerySource(
        table="feast-oss.demo_data.driver_activity"
    )
)

I would expect the above example to work the same with the BigQuerySource defined as is, or if it did foo = BigQuerySource() and foo was passed in.

Current Behavior

node = feast.Entity(name='node', join_keys=['node'])

node_temp_file_fv = feast.FeatureView(
    name='node_temperature_fv',
    entities=[node],
    schema=[
        feast.Field(name='node', dtype=feast.types.String),
        feast.Field(name='temp_f', dtype=feast.types.Int64),
    ],
    online=False,
    source=feast.FileSource(
        name='temperature_source',
        path='./data/temperature_source.parquet',
        timestamp_field='timestamp',
    )
)

$ feast apply
Created entity node
Created feature view node_temperature_fv

Created sqlite table demo_node_temperature_fv

 $ feast data-sources list
NAME    CLASS

Change the above definition:

node_temperature_file_source = feast.FileSource(
    name='temperature_source',
    path='./data/temperature_source.parquet',
    timestamp_field='timestamp',
)

node_temp_file_fv = feast.FeatureView(
    name='node_temperature_fv',
    entities=[node],
    schema=[
        feast.Field(name='node', dtype=feast.types.String),
        feast.Field(name='temp_f', dtype=feast.types.Int64),
    ],
    online=False,
    source=node_temperature_file_source
)

$ feast apply
No changes to registry
No changes to infrastructure

But despite "no changes" being made, the source is now listed:

$ feast data-sources list
NAME                CLASS
temperature_source  <class 'feast.infra.offline_stores.file_source.FileSource'>

Specifications

  • Version: Feast SDK Version: "feast 0.22.2"
  • Platform: x86_64 on Python 3.9.12
  • Subsystem: Linux 5.4.188

Activity

  1. cburroughs
    added
    kind/bug
    priority/p2
    on Aug 1, 2022
  2. cburroughs
    changed the title [-]data sources displayed different dependening on "inline" definition[/-] [+]data sources displayed different depending on "inline" definition[/+] on Aug 2, 2022
  3. kevjumba
    added
    critical
    on Aug 3, 2022
  4. felixwang9817
    self-assigned this
    on Aug 5, 2022

  5. felixwang9817 commented on Aug 5, 2022

    @felixwang9817
    felixwang9817
    on Aug 5, 2022
    Collaborator
    More actions

    I was able to repro this - the issue is with how we're parsing repos (parse_repo in repo_operations.py)

    specifically, when we have an inline data source defined, we're just not registered it to be applied

    I should have a fix out soon!

    Reacted by Chris Burroughs
  6. feast-ci-bot
    closed this as completedin #3036on Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

  • @felixwang9817
    felixwang9817

Labels

criticalkind/bugpriority/p2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
    You are visitor 01402520 — GeezerVison does not store the pages you look up.
    Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.