GeezerVison is showing github.com — crash (segfault?) on protobuf>=4.24.0 · Issue #3921 · feast-dev/feast
crash (segfault?) on protobuf>=4.24.0 #3921DescriptionExpected Behavior
Feast should not crash.
Current Behavior
As commented in 028cc20, Feast crashes with protobuf>=4.24.0. The most recent version of protobuf that Feast can use is 4.23 which stopped being supported in August of 2023 https://protobuf.dev/support/version-support/
Steps to reproduce
I see this on feast apply, the original report is unclear. Activityshuchu commented on Feb 2, 2024 this one seems an urgent bug. shuchu commented on Feb 18, 2024 working on this. I do see segmentation errors. shuchu commented on Mar 8, 2024 cburroughs commented on Mar 8, 2024 ContributorAuthor More actions Nice find. That seems to suggest the Feast constraint should be something along the lines be <24, or >=25? shuchu commented on Mar 8, 2024 I have found the cause of this segment fault. Will have a PR to fix it today. shuchu commented on Mar 8, 2024 Here is a piece of example code that can repoduce the segmentation fault:
Please change the repo file path accordingly in your own computer.
from pathlib import Path
from feast import FeatureStore
from feast.repo_config import load_repo_config
from feast.infra.registry.file import FileRegistryStore
from feast.repo_operations import parse_repo
repo_path = Path("/home/ubuntu/feast_demo/notable_troll/")
fs_yaml_file = "/home/ubuntu/feast_demo/notable_troll/feature_repo/feature_store.yaml"
repo_config = load_repo_config(repo_path, fs_yaml_file)
fs = FeatureStore(config=repo_config)
repo = parse_repo(repo_path)
fs.plan(repo)jeremyary commented on Mar 8, 2024 notable_troll is my new favorite init output 😆
shuchu commented on Mar 8, 2024
Nice find. That seems to suggest the Feast constraint should be something along the lines be <24, or >=25?
Right now, I use ">=4.24.0". I pass the test with 4.25.3
MetadataMetadataDevelopmentNo branches or pull requestsIssue actions
|