Description

Nmroth42

opened on Mar 21, 2024

Issue body actions

SqlRegistry _apply_object doesn't take into account match with project_id when updating row.
https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/registry/sql.py#L736

Wrong (as is):
.where(getattr(table.c, id_field_name) == name)

Correct:
.where(getattr(table.c, id_field_name) == name, table.c.project_id == project)

Reacted by Tornike Gurgenidze

Activity

1. Nmroth42

   added

   kind/bug

   priority/p2

   on Mar 21, 2024
2. Nmroth42

   changed the title [-]SqlRegistry _apply_object doesn't take into account match with project_id on update[/-] [+]SqlRegistry _apply_object doesn't take into account match with project_id when updating row[/+] on Mar 21, 2024
3. tokoko commented on Mar 25, 2024

   

   tokoko

   on Mar 25, 2024

   Collaborator

   More actions

   @Nmroth42 thanks, would you like to open a PR for this?
4. Nmroth42 commented on Mar 26, 2024

   

   Nmroth42

   on Mar 26, 2024

   ContributorAuthor

   More actions

   #4042
5. jeremyary

   closed this as completedin #4042on Mar 27, 2024

Issue actions