GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add possibility to choose database name when using DatastoreOnlineStore · Issue #4113 · feast-dev/feast

Add possibility to choose database name when using DatastoreOnlineStore #4113

New issue
Copy link
New issue
Copy link
Closed
#4180
Closed
Add possibility to choose database name when using DatastoreOnlineStore#4113
#4180
Copy link
Labels
kind/featureNew feature or requestNew feature or request

Description

@Pawel-Drabczyk
Pawel-Drabczyk
opened on Apr 18, 2024
Issue body actions

Is your feature request related to a problem? Please describe.
When introducing Firestore in Datastore mode in place of Datastore, Google added a possibility to create multiple databases other than (default) (in Datastore there was only one database called (default)). Class DatastoreOnlineStore still doesn't support using a database with another name.

Describe the solution you'd like
I would like to have possibility to choose database name when using DatastoreOnlineStore

Describe alternatives you've considered
The alternative is using the (default) database. However, it has some disadvantages e.g. it doesn't allow fine-grained permissions for each user.

Additional context
Google Datastore client supports passing database when initializing the client.

Activity

  1. Pawel-Drabczyk
    added
    kind/featureNew feature or requestNew feature or request
    on Apr 18, 2024
  2. tokoko commented on Apr 19, 2024

    @tokoko
    tokoko
    on Apr 19, 2024
    Collaborator
    More actions

    thanks, would you like to open a PR for this?

  3. Pawel-Drabczyk commented on Apr 19, 2024

    @Pawel-Drabczyk
    Pawel-Drabczyk
    on Apr 19, 2024
    ContributorAuthor
    More actions

    thanks, would you like to open a PR for this?

    Sure, I will try to prepare sth on Monday :)

  4. Pawel-Drabczyk commented on May 7, 2024

    @Pawel-Drabczyk
    Pawel-Drabczyk
    on May 7, 2024
    ContributorAuthor
    More actions

    @tokoko, I have created a PR #4180, sorry for the delay.

    Reacted by Tornike Gurgenidze
  5. franciscojavierarceo
    closed this as completedin #4180on May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureNew feature or requestNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.