Description

franciscojavierarceo

opened on Jul 11, 2024

Issue body actions

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
As seen in #4293, the PyPi package failed because of a dependency in a feast installation that uses an extra.

pip install feast[sqlite_vec]

This can be added to the existing build_wheels ci by testing a python import. If the import fails, we should fail the build/release.

Describe alternatives you've considered
We should have the CI test building the main feast package before release/deployment as well each extra/add-on.

Additional context
Add any other context or screenshots about the feature request here.

Activity

1. franciscojavierarceo

   added

   kind/featureNew feature or requestNew feature or request

   starter-ticketGood starter ticketsGood starter tickets

   on Jul 11, 2024
2. tokoko commented on Jul 12, 2024

   

   tokoko

   on Jul 12, 2024

   Collaborator

   More actions

   Not exactly the same, but this can be mostly covered by #4185 I think.
3. franciscojavierarceo commented on Sep 3, 2024

   

   franciscojavierarceo

   on Sep 3, 2024

   MemberAuthor

   More actions

   We should have the quickstart run before the release as well: https://docs.feast.dev/getting-started/quickstart
4. dmartinol commented on Sep 13, 2024

   

   dmartinol

   on Sep 13, 2024

   Contributor

   More actions

   This can be added to the existing build_wheels ci by testing a python import. If the import fails, we should fail the build/release.

   What module would you import, how can we know the modules to validate? I tried with the blamed version 0.39.0:

   % pip install -q feast==0.39.0
   % feast version
   Feast SDK Version: "0.39.0"
   % python -c "import feast"
   % python -c "import sqlite_vect" 
   Traceback (most recent call last):
     File "<string>", line 1, in <module>
   ModuleNotFoundError: No module named 'sqlite_vect'
5. franciscojavierarceo commented on Sep 13, 2024

   

   franciscojavierarceo

   on Sep 13, 2024

   MemberAuthor

   More actions

   You have a typo in "vec"

   Reacted by Daniele Martinoli
6. franciscojavierarceo commented on Sep 13, 2024

   

   franciscojavierarceo

   on Sep 13, 2024

   MemberAuthor

   More actions

   But this CI validation would ideally run on all of the extras.
7. dmartinol commented on Sep 13, 2024

   

   dmartinol

   on Sep 13, 2024

   Contributor

   More actions

   You have a typo in "vec"
   thanks for noticing, anyway it fails (as expected) for version 0.39.0:

   % python -c "import sqlite_vec"
   Traceback (most recent call last):
     File "<string>", line 1, in <module>
   ModuleNotFoundError: No module named 'sqlite_vec'

   But this CI validation would ideally run on all of the extras.
   You mean:

   • read all the extras configured in setup.py
   • for each extra module m run python -c "import <m>" || exit 1

   @franciscojavierarceo I need your feedback to move on with this solution. Thanks!
8. tokoko

   closed this as completedin #4533on Sep 22, 2024

Issue actions