GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Project name is having missing validation to llimit the size · Issue #4626 · feast-dev/feast

Project name is having missing validation to llimit the size #4626

New issue
Copy link
New issue
Copy link
Closed
Closed
Project name is having missing validation to llimit the size#4626
Copy link
Labels
kind/bugpriority/p2

Description

@lokeshrangineni
lokeshrangineni
opened on Oct 14, 2024
Issue body actions

Expected Behavior

Based on the documentation project name should be limited to 16 chars along with other validations only to allow alpha numeric characters and allow _ but not as a beginning character.

Ask is - We have to update the documentation to reflect the current behavior of the product.

Current Behavior

Current behavior does not limit the project length. Allows unlimited chars.

Steps to reproduce

  • do the feast init to create a new feast repo with default configurations.
  • go to feature_repo folder after the repo creation.
  • modify the feature_store.yaml file and update the project name to more than 16 chars.
  • execute feast apply command.

Activity

  1. lokeshrangineni
    added
    kind/bug
    priority/p2
    on Oct 14, 2024
  2. lokeshrangineni
    added 5 commits that reference this issue on Oct 14, 2024

    Added the fix to add missing project length validation.

    85f8895

    Added the fix to add missing project length validation.

    1641c43

    Added the fix to add missing project length validation.

    3d3a2cd

    Updated the documentation to make it clear after spending some time.

    235fd43

    Updated the documentation to make it clear after spending some time.

    ca8ce3a
  3. franciscojavierarceo
    added a commit that references this issue on Oct 14, 2024

    fix: Updating the documentation and adding tests for project length (#…

    945b0fa
  4. robhowley
    added a commit that references this issue on Oct 16, 2024

    fix: Updating the documentation and adding tests for project length (f…

    3976b7e
  5. lokeshrangineni commented on Oct 16, 2024

    @lokeshrangineni
    lokeshrangineni
    on Oct 16, 2024
    ContributorAuthor
    More actions

    Created the PR to address the issue - #4628
    We can close this ticket.

  6. lokeshrangineni
    closed this as completedon Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugpriority/p2

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.