GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove unused (and out-of-place) FeatureStore.version function · Issue #4747 · feast-dev/feast

Remove unused (and out-of-place) FeatureStore.version function #4747

New issue
Copy link
New issue
Copy link
Closed
Closed
Remove unused (and out-of-place) FeatureStore.version function#4747
Copy link
Labels
kind/bugpriority/p2

Description

@dandawg
dandawg
opened on Nov 7, 2024
Issue body actions

The FeatureStore class has a version function which returns the Python SDK version. This gives the illusion that it is needed in the class, but it is never actually used. When I first saw it, I was confused why the class would have a version (which is why I dug into the source code). I propose simplifying the FeatureStore class by dropping the FeatureStore.version function.

The benefit will be making the code easier to understand, with less opportunity for error.

Expected Behavior

I expect the FeatureStore class not to have a version function, as it is not used and not needed.

Even if it were needed, the better way to get the version would be either directly through the function it calls (version.get_version -- also part of the SDK), or by calling feast.__version__.

Current Behavior

The FeatureStore class defines a version function that is never used.

feast/sdk/python/feast/feature_store.py

Line 174 in e9cd373

def version(self) -> str:

Steps to reproduce

Specifications

  • Version: 0.41.3
  • Platform: NA
  • Subsystem: NA

Activity

  1. dandawg
    added
    kind/bug
    priority/p2
    on Nov 7, 2024
  2. dandawg
    closed this as completedon Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugpriority/p2

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402520 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.