GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support PVC accessModes in Feast Go operator · Issue #4853 · feast-dev/feast

Support PVC accessModes in Feast Go operator #4853

New issue
Copy link
New issue
Copy link
Closed
Closed
Support PVC accessModes in Feast Go operator#4853
Copy link
Labels
kind/featureNew feature or requestNew feature or request

Description

@dandawg
dandawg
opened on Dec 16, 2024
Issue body actions

Is your feature request related to a problem? Please describe.
Currently when deploying Feast PVC-backed services with the Feast Go operator, the accessModes list is hard coded to ["ReadWriteMany"]. Different use cases will likely require setting the accessModes list to something different, and users should be able to make the choice of which access modes they would like for each of the Feast services (Online, Offline, Registry) that have PVC-backed storage.

Describe the solution you'd like
We propose adding an accessModes field to spec.services.<service>.persistence.file.pvc.create in the FeatureStore CRD. Users would then be able to set this field when deploying Feast resources.

  spec:
    feastProject: sample
    services:
      onlineStore:
        persistence:
          file:
            pvc:
              create:
                accessModes:
                - ReadWriteOnce
                - ReadWriteMany

We will also update the Feast Go operator to take care of setting and managing the PVC accessModes.
As part of this change, we propose setting the default access mode to ReadWriteOnce (the setting used if a user requires a PVC, but doesn't explicitly provide the accessModes field in the resource YAML).

Describe alternatives you've considered
The current functionality is that PVC access modes are hard coded to one value (in the Feast operator), and the user has no choice.

Additional context
Work for this issue is progressing in PR #4851.
Docs on PVCs: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#persistentvolumeclaims

Reacted by Tommy Hughes IV

Activity

  1. dandawg
    added
    kind/featureNew feature or requestNew feature or request
    on Dec 16, 2024
  2. tchughesiv
    closed this as completedon Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureNew feature or requestNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.