Description

astronautas

opened on Dec 15, 2025

Issue body actions

Expected Behavior

On-demand feature views (ODFVs) with write_to_online_store=True should be materialized to the online store, but they should never be queried from the offline store (ODFVs, no data for them in the offline store).

Current Behavior

ODFVs with write_to_online_store=True are being queried from offline stores. In the code here
, if an ODFV has the write_to_online_store flag set, it is treated as a regular feature view. As a result, it gets queried from the offline store.

However, ODFVs are not historical feature views and do not have any data in offline stores, so they should never be queried there.

Steps to reproduce

Run get_historical_features for an ODFV with write_to_online_store=True.

Specifications

• Version: 0.57.0
• Clickhouse offline store.

Possible Solution

Not sure yet, but basically remove the condition? Is it even needed here? Seems incorrect...

Reacted by povbab and Francisco Javier Arceo

Activity

1. astronautas

   added

   kind/bug

   priority/p2

   on Dec 15, 2025
2. astronautas commented on Dec 15, 2025

   

   astronautas

   on Dec 15, 2025

   ContributorAuthor

   More actions

   @franciscojavierarceo You added this condition, could you elaborate why it's needed? It's crashing our offline store after upgrade, but we really need write_to_online_store=True for inference efficiency :D.
3. astronautas

   changed the title [-]ODFVs with write_to_online_store=True crash offline stores (they shouldn't be queried from offline)[/-] [+]ODFVs with write_to_online_store=True crash offline stores (they get queried from offline store, but shouldn't)[/+] on Dec 15, 2025
4. franciscojavierarceo commented on Dec 15, 2025

   

   franciscojavierarceo

   on Dec 15, 2025

   Member

   More actions

   It shouldn't be, let me try and take it out. Unless you can quickly, I'm working on something else for the pytorch announcement. If you can cut a quick PR we can get it in the next release (which I'm hoping to do today or tomorrow).

   CC @ntkathole
5. astronautas commented on Dec 16, 2025

   

   astronautas

   on Dec 16, 2025

   ContributorAuthor

   More actions

   @franciscojavierarceo I can do it myself, no worries ;). Just wanted to see why it was done that way and if it makes sense to remove it.
6. franciscojavierarceo commented on Jan 27, 2026

   

   franciscojavierarceo

   on Jan 27, 2026

   Member

   More actions

   Fixed, thanks @astronautas
7. franciscojavierarceo

   closed this as completedon Jan 27, 2026
8. astronautas commented on Jan 27, 2026

   

   astronautas

   on Jan 27, 2026

   ContributorAuthor

   More actions

   no worries!

   Reacted by Francisco Javier Arceo

Issue actions