GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — dbt integration: Validate entity column data type is appropriate · Issue #5876 · feast-dev/feast Closed DescriptionContextPR #5827 added dbt integration that creates Entity objects from dbt model columns. ProblemNo validation that the entity column has an appropriate data type for use as an entity key. Entity keys should typically be:
But the code would accept any column type including:
Current Behavior# In dbt_import.py:191-197 if entity_column not in column_names: click.echo(warning) continue # No type checking! Proposed SolutionAdd validation and warning: entity_col = next((c for c in model.columns if c.name == entity_column), None) if entity_col: normalized_type = entity_col.data_type.upper() valid_entity_types = ['STRING', 'TEXT', 'VARCHAR', 'INT', 'INT32', 'INT64', 'INTEGER', 'BIGINT', 'UUID'] if not any(t in normalized_type for t in valid_entity_types): click.echo( f"{Fore.YELLOW}Warning: Entity column '{entity_column}' has type " f"'{entity_col.data_type}' which may not be suitable for entity keys." f" Recommended types: STRING, INT64{Style.RESET_ALL}" ) Edge Cases to Handle
RelatedActivity
MetadataMetadataAssigneesLabelsNo labels TypeProjectsMilestoneRelationshipsDevelopmentIssue actions |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |