GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — apply_data_source method matches by name only, without filtering by project in shared registry scenario · Issue #6206 · feast-dev/feast

apply_data_source method matches by name only, without filtering by project in shared registry scenario #6206

New issue
Copy link
New issue
Copy link
Closed
Bug
#6322
Closed
apply_data_source method matches by name only, without filtering by project in shared registry scenario#6206
Bug
#6322
Copy link
Assignees
megha2720
Labels
good first issueGood for newcomersGood for newcomerskind/bugpriority/p2starter-ticketGood starter ticketsGood starter tickets

Description

@ntkathole
ntkathole
opened on Apr 1, 2026
Issue body actions

Current Behavior

The issue is in sdk/python/feast/infra/registry/registry.py. When multiple projects share the same registry and have data sources with the same name (like the default vals_to_add), the apply_data_source method matches by name only, without filtering by project, causing cross-project overwriting.

Correctly scoped (name + project):

apply_entity (line 349-352):

if (existing_entity_proto.spec.name == entity_proto.spec.name
    and existing_entity_proto.spec.project == project):

apply_feature_service (line 447-451):

if (existing_feature_service_proto.spec.name == feature_service_proto.spec.name
    and existing_feature_service_proto.spec.project == project):

apply_feature_view (line 779-781):

if (existing_feature_view_proto.spec.name == feature_view_proto.spec.name
    and existing_feature_view_proto.spec.project == project):

BUG - name-only matching, no project filter:

apply_data_source (line 396-397):

        for idx, existing_data_source_proto in enumerate(registry.data_sources):
            if existing_data_source_proto.name == data_source.name:

delete_data_source (line 426):

if data_source_proto.name == name:

Steps to reproduce

  • feast apply for project test registers vals_to_add with project=test
  • feast apply for project test1 iterates all data_sources, finds vals_to_add from project test (matched by name only, no project check)
  • The equality check fails (they differ - at minimum different internal state), so it deletes the test version and adds a new one with project=test1

Specifications

  • Version: latest

Possible Solution

The fix would be to add the project filter to both apply_data_source and delete_data_source:


# apply_data_source fix (line 397):
if existing_data_source_proto.name == data_source.name and existing_data_source_proto.project == project:

# delete_data_source fix (line 426):
if data_source_proto.name == name and data_source_proto.project == project:

Activity

  1. ntkathole
    added
    kind/bug
    priority/p2
    good first issueGood for newcomersGood for newcomers
    starter-ticketGood starter ticketsGood starter tickets
    on Apr 1, 2026
  2. mango766
    added a commit that references this issue on Apr 1, 2026

    fix: scope data source operations by project in shared registry

    This issue will close once commit c39116d is merged into the 'master' branch.
    c39116d
  3. ntkathole
    added the
    Bug
    issue type on Apr 1, 2026
  4. megha2720 commented on Apr 2, 2026

    @megha2720
    megha2720
    on Apr 2, 2026
    More actions

    Hi! I'm a professional trainee interested in contributing to Feast. I've recently worked on XGBoost and data engineering projects. I'd love to take this on as my first issue! Could you assign it to me?

  5. ntkathole commented on Apr 2, 2026

    @ntkathole
    ntkathole
    on Apr 2, 2026
    MemberAuthor
    More actions

    @megha2720 Thanks for showing interest, I don;t see any response from @mango766 on PR raised for this issue, feel free to pick it up.

  6. ntkathole
    assigned
    megha2720
    on Apr 2, 2026
  7. mailtoboggavarapu-coder
    added 8 commits that reference this issue on Apr 20, 2026

    fix: add project filter to apply_data_source in shared registry

    This issue will close once commit 7243af3 is merged into the 'master' branch.
    7243af3

    fix: add project filter to apply_data_source and delete_data_source

    This issue will close once commit 945576e is merged into the 'master' branch.
    945576e

    fix: add project filter to apply_data_source and delete_data_source

    This issue will close once commit 9378ca8 is merged into the 'master' branch.
    9378ca8

    fix: Add project filter to apply_data_source and delete_data_source

    This issue will close once commit 5b34cbb is merged into the 'master' branch.
    5b34cbb

    test: add cross-project isolation tests for apply/delete_data_source

    This issue will close once commit 43faac7 is merged into the 'master' branch.
    43faac7

    test: add cross-project isolation tests for apply/delete_data_source

    This issue will close once commit 8a65e52 is merged into the 'master' branch.
    8a65e52

    fix: Add project filter to apply_data_source and delete_data_source (f…

    This issue will close once commit 7af2d71 is merged into the 'master' branch.
    7af2d71

    test: add cross-project isolation tests for apply/delete_data_source

    This issue will close once commit b902836 is merged into the 'master' branch.
    b902836
  8. ntkathole
    added 3 commits that reference this issue on May 1, 2026

    fix: Add project filter to apply_data_source and delete_data_source (f…

    This issue will close once commit dd8874a is merged into the 'master' branch.
    dd8874a

    test: add cross-project isolation tests for apply/delete_data_source

    This issue will close once commit b7fa291 is merged into the 'master' branch.
    b7fa291

    fix: Add project filter to apply_data_source and delete_data_source (c…

    This issue will close once commit 96562c4 is merged into the 'master' branch.
    96562c4
  9. ntkathole
    closed this as completedin #6322on May 1, 2026
  10. franciscojavierarceo
    added a commit that references this issue on May 4, 2026

    chore(release): release 0.63.0

    50ad181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

  • @megha2720
    megha2720

Labels

good first issueGood for newcomersGood for newcomerskind/bugpriority/p2starter-ticketGood starter ticketsGood starter tickets

Type

Bug

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    You are visitor 01402503 — GeezerVison does not store the pages you look up.
    Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.