Description

mattiamatrix

opened on Apr 21, 2026

Issue body actions

Expected Behavior

Temporary entity tables created during get_historical_features() should be cleaned up after the retrieval job completes, consistent with how BigQuery, Redshift, and Athena handle it.

Current Behavior

Each call to get_historical_features() with a pandas DataFrame entity_df creates a permanent table ({catalog}.{dataset}.feast_entity_df_<uuid>) that is never dropped, leaking tables in the Trino catalog indefinitely.

Steps to reproduce

1. This is a known issue in TrinoOfflineStore https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py#L486

Specifications

• Version: 0.50+
• Platform: Any
• Subsystem: TrinoOfflineStore

Possible Solution

Refactor TrinoRetrievalJob to accept a context manager (query_generator) instead of a plain query string, following the pattern used by BigQuery/Redshift/Athena, and add a DROP TABLE IF EXISTS in the finally block.

Activity

1. mattiamatrix

   changed the title [-]Trino offline store leaks temporary entity tables (no cleanup)[/-] [+]`TrinoOfflineStoreConfig` does not cleanup temporary tables[/+] on Apr 21, 2026
2. mattiamatrix

   changed the title [-]`TrinoOfflineStoreConfig` does not cleanup temporary tables[/-] [+]`TrinoOfflineStore` does not cleanup temporary tables[/+] on Apr 21, 2026
3. Jwrede

   added 2 commits that reference this issue on May 14, 2026

   fix(trino): Clean up temporary entity tables after retrieval

   This issue will close once commit 231e03a is merged into the 'master' branch.

   231e03a

   fix(trino): Clean up temporary entity tables after retrieval

   This issue will close once commit d22bb4a is merged into the 'master' branch.

   d22bb4a
4. ntkathole

   added 3 commits that reference this issue on May 14, 2026

   fix(trino): Clean up temporary entity tables after retrieval

   This issue will close once commit 8d277c1 is merged into the 'master' branch.

   8d277c1

   fix(trino): Clean up temporary entity tables after retrieval

   This issue will close once commit 317adfa is merged into the 'master' branch.

   317adfa

   fix(trino): Clean up temporary entity tables after retrieval (#6381)

   This issue will close once commit d86b13d is merged into the 'master' branch.

   d86b13d
5. ntkathole

   closed this as completedin #6381on May 14, 2026
6. rpathade

   added 2 commits that reference this issue on May 21, 2026

   fix(trino): Clean up temporary entity tables after retrieval (feast-d…

   This issue will close once commit cae7a39 is merged into the 'master' branch.

   cae7a39

   fix(trino): Clean up temporary entity tables after retrieval (feast-d…

   This issue will close once commit 78fcd72 is merged into the 'master' branch.

   78fcd72
7. ntkathole

   added a commit that references this issue on May 23, 2026

   feat: Add enabled/disabled toggle for feature views (#6401)

   This issue will close once commit 5f1fa0d is merged into the 'master' branch.

   5f1fa0d
8. franciscojavierarceo

   added a commit that references this issue on Jun 13, 2026

   chore(release): release 0.64.0

   9bb73cc
9. Srihari1192

   added a commit that references this issue on Jun 22, 2026

   chore(release): release 0.64.0

   22c3721

Issue actions