GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Wire ComputeEngine.get_historical_features() into the standard retrieval path to replace per-store BFV transformation duplication · Issue #6359 · feast-dev/feast Open Labels DescriptionBackground Feast currently has two separate mechanisms for applying BatchFeatureView (BFV) transformations during historical feature retrieval:
Because of this split, each offline store that wants BFV compute-on-read during historical retrieval must re-implement transformation detection and application logic independently:
This means transformation logic is duplicated across stores rather than living in the shared compute engine layer. Root Cause passthrough_provider.get_historical_features() always delegates to self.offline_store, never to self.batch_engine: Note the contrast with materialization, which correctly routes through the engine:
Blocking Interface Mismatch The compute engine cannot be directly substituted today because of a fundamental impedance mismatch:
The compute engine is designed for per-view DAG execution. The PIT join logic that combines multiple views into one entity-aligned training dataset lives in each offline store's SQL template, not in the compute engine. Proposed Solution This is a multi-step refactor: Step 1 — Extend HistoricalRetrievalTask to support multiple feature views: Step 2 — Move PIT join coordination into ComputeEngine.get_historical_features(): The base ComputeEngine should orchestrate per-view DAG execution across all requested feature views and join the results back to entity_df — making the PIT join logic engine-owned rather than SQL-template-owned. Step 3 — Wire the provider to call batch_engine for historical retrieval: Step 4 — Retire per-store transformation logic: Once the compute engine owns this path, the custom BFV transformation code in RayOfflineStore and SparkOfflineStore can be removed. All stores get transformation support for free through the engine's FeatureBuilder. Reacted by Vinigama ActivityMetadataMetadataAssigneesLabelsTypeProjectsMilestoneRelationshipsDevelopmentIssue actions |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |