GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — sqlite.py's OnlineStore.plan() raises typeguard.TypeCheckError for stream feature views · Issue #6658 · feast-dev/feast Closed DescriptionExpected Behavior
Current BehaviorFeast has two kinds of feature views: regular ones (
def plan( self, config: RepoConfig, desired_registry_proto: RegistryProto ) -> List[InfraObject]: ... infra_objects: List[InfraObject] = [ SqliteTable( path=self._get_db_path(config), name=_table_id(project, FeatureView.from_proto(view), versioning), ) for view in [ *desired_registry_proto.feature_views, *desired_registry_proto.stream_feature_views, ] ]
In short: We ran into this adding Steps to reproducefrom feast import FileSource from feast.data_format import JsonFormat from feast.data_source import KafkaSource from feast.stream_feature_view import StreamFeatureView from feast.infra.online_stores.sqlite import SqliteOnlineStore from feast.protos.feast.core.Registry_pb2 import Registry as RegistryProto from feast.repo_config import RepoConfig config = RepoConfig(project="p", registry="/tmp/x.db", provider="local", online_store="sqlite") stream_fv = StreamFeatureView( name="driver_dropoffs_stream", entities=[], schema=[], source=KafkaSource( name="k", timestamp_field="event_timestamp", message_format=JsonFormat(schema_json=""), kafka_bootstrap_servers="localhost:9092", topic="t", batch_source=FileSource(path="dummy.parquet", timestamp_field="event_timestamp"), ), ) registry_proto = RegistryProto() registry_proto.stream_feature_views.append(stream_fv.to_proto()) SqliteOnlineStore().plan(config, registry_proto) # raises typeguard.TypeCheckError Full traceback: Specifications
Possible SolutionUse the matching class for each list instead of views = [ FeatureView.from_proto(view) for view in desired_registry_proto.feature_views ] + [ StreamFeatureView.from_proto(view) for view in desired_registry_proto.stream_feature_views ] Opened a PR with this fix: #6659 Activity
MetadataMetadataAssigneesLabelsNo labels TypeProjectsMilestoneRelationshipsDevelopmentIssue actions |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |