GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add more validation in feature spec registration by pradithya · Pull Request #11 · feast-dev/feast

Conversation

@pradithya

@pradithya pradithya commented Dec 20, 2018

Copy link
Copy Markdown
Collaborator

Add validation in feature spec registration to prevent users from registering feature that uses unsupported storage.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Pradithya Aria
Add validation in feature spec registration to prevent user from usin…
1aa05dc 
…g unsupported storage.
@pradithya
pradithya requested review from woop and zhilingc December 20, 2018 11:26
woop
woop approved these changes Dec 20, 2018
View reviewed changes

@woop woop left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zhilingc zhilingc mentioned this pull request Dec 21, 2018
Ingestion should fail immediately when there are no valid stores #12
Closed
zhilingc
zhilingc approved these changes Dec 24, 2018
View reviewed changes

@zhilingc zhilingc left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zhilingc
zhilingc merged commit 3b17d7a into master Dec 24, 2018
@zhilingc
zhilingc deleted the feature_spec_validation branch December 24, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes
@zhilingc zhilingc zhilingc approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pradithya @woop @zhilingc
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.