GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove granularity by pradithya · Pull Request #162 · feast-dev/feast

Conversation

@pradithya

@pradithya pradithya commented Mar 22, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Removal of granularity from all component of Feast.
Feature ID now has format of "[entity_name].[feature_name]".

The implementation has been tested in development cluster.

Fix #17

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Pradithya Aria and others added 19 commits March 21, 2019 11:05
Pradithya Aria
Remove granularity from proto files
926271b
Pradithya Aria
Remove granularity from serving
61a372e
Pradithya Aria
Remove granularity from proto files
99b2ed9
Pradithya Aria
Remove granularity from serving
a44af41
zhilingc
Merge branch 'remove_granularity' of github.com:pradithya/feast into …
866650f 
…remove_granularity
zhilingc
Remove granularity from core
d829e81
@davidheryanto
Remove granularity from Python SDK
08cac13
zhilingc
Update generated protos, remove granularity
34815a7
zhilingc
Merge branch 'remove_granularity' of github.com:pradithya/feast into …
f0ec475 
…remove_granularity
Pradithya Aria
Remove granularity from ingestion
22f7177
zhilingc
Scrub additional mentions of granularity
f361440
Pradithya Aria
Update core-deploy template
7688c62
Pradithya Aria
Merge branch 'remove_granularity' of github.com:pradithya/feast into …
170dc82 
…remove_granularity
Pradithya Aria
Update chart distribution
5e1ed97
zhilingc
Fix core service not overriding storage correctly
3e36892
zhilingc
Merge branch 'remove_granularity' of github.com:pradithya/feast into …
98c5757 
…remove_granularity
zhilingc
Shade core jar to include google nio lib
e4a2c07
Pradithya Aria
Remove granularity from UI
2d46ae3
Pradithya Aria
Update feature details page
bf0aad0
@feast-ci-bot feast-ci-bot added the size/XXL label Mar 22, 2019
@zhilingc

zhilingc commented Mar 22, 2019

Copy link
Copy Markdown
Collaborator

Also fixed a few small bugs introduced by PR #154.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zhilingc

zhilingc commented Mar 22, 2019

Copy link
Copy Markdown
Collaborator

/approve
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot

feast-ci-bot commented Mar 22, 2019

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [zhilingc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot feast-ci-bot added the approved label Mar 22, 2019
@davidheryanto
Update Importer in Feast Python SDK to handle source options properly
dd89477 
When the import source type is DataFrame
@zhilingc

zhilingc commented Mar 22, 2019

Copy link
Copy Markdown
Collaborator

/lgtm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot feast-ci-bot assigned zhilingc Mar 22, 2019
@feast-ci-bot feast-ci-bot added the lgtm label Mar 22, 2019
@feast-ci-bot
feast-ci-bot merged commit cf45d0f into feast-dev:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zhilingc zhilingc

Labels

approved lgtm size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pradithya @zhilingc @feast-ci-bot @davidheryanto
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.