GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Add default ttl for feature views by felixwang9817 · Pull Request #3037 · feast-dev/feast

Conversation

@felixwang9817

@felixwang9817 felixwang9817 commented Aug 8, 2022

Copy link
Copy Markdown
Collaborator

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@felixwang9817
Add default ttl for fv and sfv
116f527 
Signed-off-by: Felix Wang <[email protected]>
@feast-ci-bot feast-ci-bot added approved size/S labels Aug 8, 2022
@codecov-commenter

codecov-commenter commented Aug 8, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #3037 (c3c3c47) into master (1996596) will decrease coverage by 9.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3037      +/-   ##
==========================================
- Coverage   67.66%   58.61%   -9.06%     
==========================================
  Files         167      198      +31     
  Lines       14691    16344    +1653     
==========================================
- Hits         9941     9580     -361     
- Misses       4750     6764    +2014
Flag Coverage Δ
integrationtests ?
unittests 58.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_view.py 92.66% <ø> (-4.00%) ⬇️
sdk/python/feast/stream_feature_view.py 90.35% <ø> (+14.03%) ⬆️
...fline_store/test_universal_historical_retrieval.py 28.75% <ø> (-71.25%) ⬇️
sdk/python/tests/unit/diff/test_registry_diff.py 100.00% <ø> (+83.78%) ⬆️
...sts/integration/registration/test_universal_cli.py 20.20% <0.00%> (-79.80%) ⬇️
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 29.50% <0.00%> (-70.50%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.55% <0.00%> (-69.30%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
... and 154 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@felixwang9817 felixwang9817 mentioned this pull request Aug 8, 2022
fix: Parse inline data sources #3036
Merged
adchia
adchia approved these changes Aug 9, 2022
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@feast-ci-bot feast-ci-bot assigned adchia Aug 9, 2022
@feast-ci-bot feast-ci-bot added the lgtm label Aug 9, 2022
achals
achals approved these changes Aug 9, 2022
View reviewed changes

@achals achals left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@feast-ci-bot feast-ci-bot assigned achals Aug 9, 2022
@feast-ci-bot

feast-ci-bot commented Aug 9, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@felixwang9817
Fix test
c3c3c47 
Signed-off-by: Felix Wang <[email protected]>
@feast-ci-bot feast-ci-bot removed the lgtm label Aug 9, 2022
@kevjumba

kevjumba commented Aug 9, 2022

Copy link
Copy Markdown
Collaborator

/lgtm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot feast-ci-bot assigned kevjumba Aug 9, 2022
@feast-ci-bot feast-ci-bot added the lgtm label Aug 9, 2022
@feast-ci-bot
feast-ci-bot merged commit af5123f into feast-dev:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes
@adchia adchia adchia approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@achals achals

@adchia adchia

@kevjumba kevjumba

Labels

approved lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@felixwang9817 @codecov-commenter @feast-ci-bot @kevjumba @achals @adchia
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.