GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Remove parens from postgres source query by david-dest01 · Pull Request #3807 · feast-dev/feast

Conversation

@david-dest01

@david-dest01 david-dest01 commented Oct 18, 2023

Copy link
Copy Markdown

What this PR does / why we need it:
This PR removes the parens from a query in the PostgresSQLSource which were preventing it to successfully retrieve and materialize from table references.
 
Was previously not supported because of bug

source=PostgreSQLSource(
    name="source_user_events_v0",
    timestamp_field="created_at",
    table="offline_store.user_events"
)

 
Is now supported

source=PostgreSQLSource(
    name="source_user_events_v0",
    timestamp_field="created_at",
    table="offline_store.user_events"
)

source=PostgreSQLSource(
    name="source_user_events_v0",
    timestamp_field="created_at",
    query="select * from offline_store.user_events"
)

 
Which issue(s) this PR fixes:

Fixes #(#3804)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
david-dest01 added 3 commits October 18, 2023 07:29
@david-dest01
remove parents to support table references
12f63b4
@david-dest01
remove parens from postgres retrieval job query
3804b25
@david-dest01
Merge branch 'master' into issue-3804
b625e0d
@david-dest01 david-dest01 changed the title fix:remove parents from postgres source query fix:remove parens from postgres source query Oct 18, 2023
@david-dest01 david-dest01 changed the title fix:remove parens from postgres source query fix: remove parens from postgres source query Oct 18, 2023
@achals achals changed the title fix: remove parens from postgres source query fix: Remove parens from postgres source query Oct 20, 2023
@david-dest01

david-dest01 commented Oct 28, 2023

Copy link
Copy Markdown
Author

@achals lmk if you need anything else here
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@achals achals added lgtm ok-to-test approved labels Oct 29, 2023
@achals

achals commented Oct 29, 2023

Copy link
Copy Markdown
Member

@david-dest01 Do you mind fixing DCO? https://github.com/feast-dev/feast/pull/3807/checks?check_run_id=17817796280
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@achals

achals commented Oct 29, 2023

Copy link
Copy Markdown
Member

Looks good to me otherwise
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sudohainguyen sudohainguyen closed this Feb 18, 2024
@david-dest01 david-dest01 mentioned this pull request Mar 20, 2024
bug:postgres source invalid pull_latest_from_table_or_query query output #3804
Closed
@job-almekinders

job-almekinders commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

Hey all, I've opened a similar PR #4026.

If any one of you has the time to take a look this would be highly appreciated! @achals @sudohainguyen
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

approved lgtm ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@david-dest01 @achals @job-almekinders @sudohainguyen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.