GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Support pandas 2 by sudohainguyen · Pull Request #3928 · feast-dev/feast

Conversation

@sudohainguyen

@sudohainguyen sudohainguyen commented Feb 4, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Relax pandas upper bound to support v2.0

Which issue(s) this PR fixes:

Fixes #3709

Additional changes:

Set upper bound for moto due to its recent breaking changes in 5.0.0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sudohainguyen
sudohainguyen force-pushed the deps branch 3 times, most recently from 095047b to b321bfa Compare February 4, 2024 13:00
@sudohainguyen
sudohainguyen requested a review from shuchu February 4, 2024 13:46
@sudohainguyen

sudohainguyen commented Feb 4, 2024

Copy link
Copy Markdown
Collaborator Author

pending on #3925
cc: @franciscojavierarceo
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sudohainguyen
sudohainguyen force-pushed the deps branch from 1a505ab to 62f5e3e Compare February 5, 2024 02:43
@sudohainguyen
sudohainguyen requested a review from franciscojavierarceo February 5, 2024 02:53
@sudohainguyen sudohainguyen added approved ok-to-test labels Feb 5, 2024
@franciscojavierarceo franciscojavierarceo added ok-to-test and removed ok-to-test labels Feb 5, 2024
@sudohainguyen

sudohainguyen commented Feb 5, 2024

Copy link
Copy Markdown
Collaborator Author

seems the issue appears in integration tests related to this issue from pandas pandas-dev/pandas#55730

we need to pin pandas version to at least 2.1.3 in order to adopt pandas v2, however the library only supports python 3.8 till 2.0.3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sudohainguyen sudohainguyen removed the approved label Feb 5, 2024
@sudohainguyen

sudohainguyen commented Feb 5, 2024

Copy link
Copy Markdown
Collaborator Author

Note: just run local integration tests successfully on python 3.10, pandas 2.2.0
however it's not possible to make python 3.8 + pandas 2 + feast work together, if users install py 3.8 with feast, they shall not use pandas v2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sudohainguyen sudohainguyen mentioned this pull request Feb 5, 2024
ci: Extend python base version for test cases #3929
Merged
@sudohainguyen
sudohainguyen force-pushed the deps branch from 61ba10a to c7ece08 Compare February 5, 2024 16:26
haoxu0
haoxu0 approved these changes Feb 6, 2024
View reviewed changes

@haoxu0 haoxu0 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicee!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sudohainguyen
sudohainguyen force-pushed the deps branch from c7ece08 to 057ee5a Compare February 6, 2024 06:31
@sudohainguyen

sudohainguyen commented Feb 6, 2024

Copy link
Copy Markdown
Collaborator Author

still err, hang on, working on it
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sudohainguyen sudohainguyen added the dependencies Pull requests that update a dependency file label Feb 11, 2024
sudohainguyen added 5 commits February 16, 2024 00:01
@sudohainguyen
chore: Support pandas 2
c7059ce 
Signed-off-by: Hai Nguyen <[email protected]>
@sudohainguyen
chore: Generate reqs for py38 and py39
94036fd 
Signed-off-by: Hai Nguyen <[email protected]>
@sudohainguyen
fix: Update imports in mysql unit test
3a5011b 
Signed-off-by: Hai Nguyen <[email protected]>
@sudohainguyen
fix: Set upper bound for moto
83b1160 
Signed-off-by: Hai Nguyen <[email protected]>
@sudohainguyen
fix: Recompile ci deps py38 py39
09bdff6 
Signed-off-by: Hai Nguyen <[email protected]>
@sudohainguyen
sudohainguyen force-pushed the deps branch from 057ee5a to 09bdff6 Compare February 16, 2024 01:37
@sudohainguyen sudohainguyen closed this Feb 18, 2024
@sudohainguyen sudohainguyen mentioned this pull request Feb 18, 2024
feat: Pandas v2 compatibility #3957
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haoxu0 haoxu0 haoxu0 approved these changes
@shuchu shuchu Awaiting requested review from shuchu
@franciscojavierarceo franciscojavierarceo Awaiting requested review from franciscojavierarceo

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pandas 2.0 support

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sudohainguyen @haoxu0 @franciscojavierarceo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.