GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||
GeezerVison is showing github.com — chore: Refactoring to fix mypy linting by bushwhackr · Pull Request #3947 · feast-dev/feast Conversation
Contributor
What this PR does / why we need it: mypy lint fixes, refer to: #3938 subset of mypy linting fixes when mypy version was upgraded in #3938. The PR is getting alittle too long, so I'm breaking into another PR for the final fixes. ~/repo/feast ❯ cd sdk/python/; mypy feast/feature_store.py:1009: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] feast/repo_operations.py:249: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] feast/repo_operations.py:263: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] feast/infra/utils/snowflake/snowflake_utils.py:124: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] tests/utils/feature_records.py:335: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] tests/unit/test_registry_server.py:22: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] tests/unit/test_registry_server.py:33: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] tests/unit/test_registry_server.py:51: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] feast/infra/materialization/contrib/bytewax/bytewax_materialization_dataflow.py:56: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] tests/integration/registration/test_universal_types.py:337: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] tests/integration/registration/test_universal_types.py:356: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] tests/integration/feature_repos/repo_configuration.py:169: error: Value expression in dictionary comprehension has incompatible type "Tuple[Union[str, Dict[Any, Any], None], Optional[Type[OnlineStoreCreator]]]"; expected type "Tuple[Union[str, Dict[str, str]], Optional[Type[OnlineStoreCreator]]]" [misc] tests/integration/feature_repos/repo_configuration.py:350: error: Argument "driver_odfv" to "UniversalFeatureViews" has incompatible type "Optional[OnDemandFeatureView]"; expected "OnDemandFeatureView" [arg-type] tests/integration/feature_repos/repo_configuration.py:351: error: Argument 1 to "conv_rate_plus_100_feature_view" has incompatible type "List[Any]"; expected "Dict[str, Union[RequestSource, FeatureView]]" [arg-type] tests/integration/feature_repos/repo_configuration.py:375: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] tests/integration/feature_repos/repo_configuration.py:412: error: Incompatible types in assignment (expression has type "FeastConfigBaseModel", variable has type "Union[str, Dict[Any, Any], None]") [assignment] tests/integration/feature_repos/repo_configuration.py:415: error: Incompatible types in assignment (expression has type "Union[str, Dict[Any, Any], None]", variable has type "FeastConfigBaseModel") [assignment] tests/integration/feature_repos/repo_configuration.py:422: error: Missing named argument "feature_logging" for "AwsLambdaFeatureServerConfig" [call-arg] tests/integration/feature_repos/repo_configuration.py:431: error: Incompatible types in assignment (expression has type "LocalFeatureServerConfig", variable has type "AwsLambdaFeatureServerConfig") [assignment] tests/integration/feature_repos/repo_configuration.py:446: error: Missing named argument "registry_store_type" for "RegistryConfig" [call-arg] tests/integration/feature_repos/repo_configuration.py:446: error: Missing named argument "s3_additional_kwargs" for "RegistryConfig" [call-arg] tests/conftest.py:222: error: Incompatible types in assignment (expression has type "List[Tuple[str, Any]]", variable has type "Optional[List[Optional[Tuple[str, Type[DataSourceCreator]]]]]") [assignment] tests/conftest.py:237: error: Incompatible types in assignment (expression has type "dict_values[str, Tuple[Union[str, Dict[str, str]], Optional[Type[OnlineStoreCreator]]]]", variable has type "Optional[List[Optional[Tuple[Union[str, Dict[str, str]], Optional[Type[OnlineStoreCreator]]]]]]") [assignment] tests/conftest.py:262: error: "None" object is not iterable [misc] tests/conftest.py:263: error: "None" object is not iterable [misc] tests/conftest.py:348: error: Too many arguments for "create_data_source" of "DataSourceCreator" [call-arg] tests/unit/online_store/test_online_retrieval.py:139: error: Missing named argument "registry_store_type" for "RegistryConfig" [call-arg] tests/unit/online_store/test_online_retrieval.py:139: error: Missing named argument "s3_additional_kwargs" for "RegistryConfig" [call-arg] tests/unit/online_store/test_online_retrieval.py:202: error: Missing named argument "registry_store_type" for "RegistryConfig" [call-arg] tests/unit/online_store/test_online_retrieval.py:202: error: Missing named argument "s3_additional_kwargs" for "RegistryConfig" [call-arg] tests/unit/infra/test_local_registry.py:41: error: Missing named argument "registry_store_type" for "RegistryConfig" [call-arg] tests/unit/infra/test_local_registry.py:41: error: Missing named argument "s3_additional_kwargs" for "RegistryConfig" [call-arg] tests/unit/cli/test_cli_chdir.py:21: error: List item 1 has incompatible type "Path"; expected "str" [list-item] tests/unit/cli/test_cli_chdir.py:24: error: List item 1 has incompatible type "Path"; expected "str" [list-item] tests/unit/cli/test_cli_chdir.py:28: error: List item 1 has incompatible type "Path"; expected "str" [list-item] tests/unit/cli/test_cli_chdir.py:37: error: List item 1 has incompatible type "Path"; expected "str" [list-item] tests/unit/cli/test_cli_chdir.py:47: error: List item 1 has incompatible type "Path"; expected "str" [list-item] tests/unit/cli/test_cli_chdir.py:52: error: List item 1 has incompatible type "Path"; expected "str" [list-item] tests/unit/cli/test_cli_chdir.py:55: error: List item 1 has incompatible type "Path"; expected "str" [list-item] tests/integration/registration/test_registry.py:45: error: Missing named argument "registry_store_type" for "RegistryConfig" [call-arg] tests/integration/registration/test_registry.py:45: error: Missing named argument "s3_additional_kwargs" for "RegistryConfig" [call-arg] tests/integration/registration/test_registry.py:56: error: Missing named argument "registry_store_type" for "RegistryConfig" [call-arg] tests/integration/registration/test_registry.py:56: error: Missing named argument "s3_additional_kwargs" for "RegistryConfig" [call-arg] tests/integration/offline_store/test_universal_historical_retrieval.py:170: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] tests/integration/offline_store/test_s3_custom_endpoint.py:43: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] tests/integration/offline_store/test_offline_write.py:134: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] feast/infra/offline_stores/contrib/trino_offline_store/tests/data_source.py:128: error: Missing named argument "user" for "TrinoOfflineStoreConfig" [call-arg] feast/infra/offline_stores/contrib/trino_offline_store/tests/data_source.py:128: error: Missing named argument "auth" for "TrinoOfflineStoreConfig" [call-arg] feast/infra/offline_stores/contrib/postgres_offline_store/tests/data_source.py:112: error: Return type "Dict[str, str]" of "create_online_store" incompatible with return type "FeastConfigBaseModel" in supertype "OnlineStoreCreator" [override] tests/integration/e2e/test_python_feature_server.py:131: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] Found 34 errors in 8 files (checked 430 source files) Which issue(s) this PR fixes: Fixes #
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
bushwhackr
requested review from
kevjumba,
niklasvm,
sfc-gh-madkins,
sudohainguyen and
younggyu-oh
as code owners
bushwhackr
force-pushed
the
bushwhackr/mypy
branch
from
658354f to
275d162
Compare
Signed-off-by: Chester Ong <[email protected]> Signed-off-by: Chester Ong <[email protected]> Signed-off-by: Chester Ong <[email protected]> Signed-off-by: Chester Ong <[email protected]> Signed-off-by: Chester Ong <[email protected]> Signed-off-by: Chester Ong <[email protected]> Signed-off-by: Chester Ong <[email protected]> Signed-off-by: Chester Ong <[email protected]> Signed-off-by: Chester Ong <[email protected]>
bushwhackr
force-pushed
the
bushwhackr/mypy
branch
from
275d162 to
f0f7fec
Compare
Signed-off-by: Chester Ong <[email protected]> Signed-off-by: Chester Ong <[email protected]> Signed-off-by: Chester Ong <[email protected]> Signed-off-by: Chester Ong <[email protected]>
bushwhackr
commented
Comment on lines
16
to
20
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. functionality change: due to create_data_source needing an indeterminate number of arguments. The base class should accept kwargs and the concrete class should then process user arguments on whether sufficient inputs were given.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabelsProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. 2 participantsAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||||||||||||||||||||||
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |