GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Feast/IKV online store contrib plugin integration by pushkarmoi · Pull Request #4060 · feast-dev/feast

Conversation

@pushkarmoi

@pushkarmoi pushkarmoi commented Mar 31, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
We add a new online store (IKV - https://www.inlined.io/) to feast by following the guide here:
docs.feast.dev/how-to-guides/customizing-feast/adding-support-for-a-new-online-store

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pushkarmoi added 3 commits March 31, 2024 16:02
@pushkarmoi
Feast/IKV online store contrib plugin integration
553d5b4
@pushkarmoi
Merge branch 'master' into pugupta/ikv-integration
673900d
@pushkarmoi
testing and dependency
2483c7c
@pushkarmoi pushkarmoi changed the title Feast/IKV online store contrib plugin integration feat: Feast/IKV online store contrib plugin integration Mar 31, 2024
pushkarmoi added 4 commits March 31, 2024 16:47
@pushkarmoi
sign off
d0aff21 
Signed-off-by: Pushkar Gupta <[email protected]>
@pushkarmoi
sign off
790c0e5 
Signed-off-by: Pushkar Gupta <[email protected]>
@pushkarmoi
correct pkg
75b9609
@pushkarmoi
edit pkg name
da7705c 
Signed-off-by: Pushkar Gupta <[email protected]>
@franciscojavierarceo franciscojavierarceo added the ok-to-test label Apr 1, 2024
franciscojavierarceo
franciscojavierarceo approved these changes Apr 3, 2024
View reviewed changes

@franciscojavierarceo franciscojavierarceo left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@franciscojavierarceo
franciscojavierarceo enabled auto-merge (squash) April 3, 2024 00:54
@pushkarmoi
linting errors
7c95550
auto-merge was automatically disabled April 3, 2024 01:14

Head branch was pushed to by a user without write access

@pushkarmoi
sign off
d87695a 
Signed-off-by: Pushkar Gupta <[email protected]>
tokoko
tokoko reviewed Apr 3, 2024
View reviewed changes
Comment thread setup.py Outdated
+ CASSANDRA_REQUIRED
+ AZURE_REQUIRED
+ ROCKSET_REQUIRED
+ IKV_REQUIRED

@tokoko tokoko Apr 3, 2024

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary, since we are not adding tests to run on ci at this point

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@pushkarmoi pushkarmoi Apr 3, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for flagging, removed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pushkarmoi added 4 commits April 2, 2024 22:10
@pushkarmoi
linting
a17cce2 
Signed-off-by: Pushkar Gupta <[email protected]>
@pushkarmoi
linting
ce44ff8 
Signed-off-by: Pushkar Gupta <[email protected]>
@pushkarmoi
linting
0bd3bec 
Signed-off-by: Pushkar Gupta <[email protected]>
@pushkarmoi
make format
872be0b 
Signed-off-by: Pushkar Gupta <[email protected]>
@pushkarmoi pushkarmoi mentioned this pull request Apr 3, 2024
feat: Feast/IKV online store contrib plugin integration #4068
Merged
@pushkarmoi pushkarmoi closed this Apr 3, 2024
@pushkarmoi

pushkarmoi commented Apr 3, 2024

Copy link
Copy Markdown
Contributor Author

Closed this and opened #4068 to work-around DCO issue
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tokoko tokoko tokoko left review comments
@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pushkarmoi @franciscojavierarceo @tokoko
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.