GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Omit bytewax deps and materialization engine by sudohainguyen · Pull Request #4098 · feast-dev/feast

Conversation

@sudohainguyen

@sudohainguyen sudohainguyen commented Apr 12, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

After the successful merge of PR #4087, this PR aims to remove Bytewax entirely, including its dependencies and materialization engine. This is crucial for unblocking efforts to support Python 3.11 as outlined in #4046.

Additional notes

Next action is to remove related docs and compose the new k8s engine doc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sudohainguyen
sudohainguyen requested a review from whoahbot as a code owner April 12, 2024 02:25
@sudohainguyen
sudohainguyen requested review from franciscojavierarceo and removed request for whoahbot April 12, 2024 02:25
@sudohainguyen
sudohainguyen force-pushed the bytewax-prune branch 2 times, most recently from 7d41845 to c7088ea Compare April 12, 2024 02:29
@sudohainguyen
sudohainguyen requested a review from haoxu0 April 12, 2024 03:16
@sudohainguyen
chore: Omit bytewax deps and materialization engine
96d8930
Signed-off-by: Harry <[email protected]>
@sudohainguyen
sudohainguyen force-pushed the bytewax-prune branch from c7088ea to 96d8930 Compare April 12, 2024 03:48
@sudohainguyen sudohainguyen changed the title fix: Prune bytewax dependencies chore: Omit bytewax deps and materialization engine Apr 12, 2024
haoxu0
haoxu0 approved these changes Apr 15, 2024
View reviewed changes

@haoxu0 haoxu0 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@haoxu0 haoxu0 added the ok-to-test label Apr 15, 2024
@breno-costa

breno-costa commented Apr 15, 2024

Copy link
Copy Markdown
Contributor

@sudohainguyen why are you removing bytewax? Is there any issue or RFC explaining reasons behind this decision?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sudohainguyen

sudohainguyen commented Apr 15, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author

@sudohainguyen why are you removing bytewax? Is there any issue or RFC explaining reasons behind this decision?

There are 2 main reasons:

  • the current version of bytewax we're using is blocking us from supporting python 3.11
  • we're not leveraging all features of bytewax: if you look at bytewax engine implementation, it is simply a kubernetes job with multiple of parallel pods reading files separately and writing data to the online store, which is powered by pyarrow zero-copy mechanism, so we decided to re-write the engine called k8s engine which remains the logic but without bytewax interface.

as a result, we see it is safe to remove bytewax 😄 hope this helps

breno-costa reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tokoko

tokoko commented Apr 15, 2024

Copy link
Copy Markdown
Collaborator

@breno-costa see #4087 for a replacement that Harry pointed to. The discussions around the topic started out here #3993 and then continued on slack and community calls, so unfortunately no single place to see it all.

breno-costa reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@franciscojavierarceo

franciscojavierarceo commented Apr 15, 2024

Copy link
Copy Markdown
Member

@tokoko any chance you can compile a quick doc with the decision just so we can add it as a note somewhere? Even a paragraph in the community notes would probably be sufficient.

sudohainguyen reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sudohainguyen

sudohainguyen commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator Author

@franciscojavierarceo let me handle it

franciscojavierarceo, tokoko, and breno-costa reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@franciscojavierarceo

franciscojavierarceo commented Apr 16, 2024

Copy link
Copy Markdown
Member

@sudohainguyen thank you!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@breno-costa

breno-costa commented Apr 16, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@sudohainguyen @tokoko Thanks for clarifying that point. We wanted to try a more scalable materialization engine and bytewax would be our first candidate. Let us try this new k8s implementation.

haoxu0 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@haoxu0
haoxu0 merged commit 77c78aa into feast-dev:master Apr 17, 2024
@sudohainguyen
sudohainguyen deleted the bytewax-prune branch April 18, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haoxu0 haoxu0 haoxu0 approved these changes
@franciscojavierarceo franciscojavierarceo Awaiting requested review from franciscojavierarceo

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sudohainguyen @breno-costa @tokoko @franciscojavierarceo @haoxu0
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.