GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||
GeezerVison is showing github.com — fix: Bad feature_servers/multicloud Dockerfile by bushwhackr · Pull Request #4138 · feast-dev/feast Conversation
|
$ export VERSION=0.37.1 $ export REGISTRY=docker.io $ make build-feature-server-docker [+] Building 95.1s (14/14) FINISHED docker:default => [internal] load build definition from Dockerfile 0.0s => => transferring dockerfile: 1.44kB 0.0s => [internal] load metadata for docker.io/library/python:3.9-slim 0.9s ... ... => exporting to image 3.6s => => exporting layers 3.6s => => writing image sha256:7cd5076b1023823d01b98297b06544f2ab52964aa6c690ba6b2e8492a841decf 0.0s => => naming to docker.io/library/feature-server:0.37.1 $ docker run -it docker.io/library/feature-server:0.37.1 pip show feast | grep Version Version: 0.37.1.dev16+g0e22da42.d20240423 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
cc @jeremyary |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks! We'll take a look. As far as use case goes (as far as I understand), it's a stretch to imagine an end user utilizing every cloud provider we enable, but this checks the box for ensuring whatever variant of subsets a user plugs in are good to go together. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
any blockers? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@bushwhackr apologies for taking a bit of time. We've had a backlog to work through after resolving our release process issues, so I'm slowly catching us up on PR's. If you wouldn't mind TAL at currrent conflicts, I'll work to bring in your change for our next release. Thanks again for your time spent here & contributions! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
i believe this is used during our deployment to verify the build |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I believe the original Dockerfile (with pypi installation) still useful while the users want to test official Feast releases. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| build-feature-server-dev: | ||
| docker buildx build --build-arg VERSION=dev \ | ||
| -t feastdev/feature-server:dev \ | ||
| -f sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev --load . |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
was this used at all for deploying any images? Do you want to ask achal or any of the old maintainers?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The only difference in the previous Dockerfile vs Dockerfile.dev was the COPY . . instruction.
The old Dockerfile installs only the pypi available feast package, whereas the old Dockerfile.dev installs the pypi + copies the current codebase into the image.
With the changes I made to the Dockerfile, it does not rely on pypi for the feast package and we would only use the current codebase to install feast. Essentially the same as what old Dockerfile.dev was doing.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
ah, I know the problem. In the document, Development Guide part. The last step of Environment setup is: As a result, it will call the pypi version.... |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Signed-off-by: Chester Ong <[email protected]>
Signed-off-by: Chester Ong <[email protected]>
0e22da4 to
015da38
Compare
Signed-off-by: Chester Ong <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.