GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Update CI-related AWS settings due to cred swap & global namespace issues by jeremyary · Pull Request #4171 · feast-dev/feast

Conversation

@jeremyary

@jeremyary jeremyary commented May 2, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Updates needed in code following AWS credential swap in Action secrets for CI executions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jeremyary
chore: Bumping CI to test new cloud creds, do not merge
76432ea 
Signed-off-by: Jeremy Ary <[email protected]>
@jeremyary jeremyary added the ok-to-test label May 2, 2024
@jeremyary
jeremyary requested a review from younggyu-oh as a code owner May 3, 2024 15:40
@jeremyary
jeremyary removed the request for review from younggyu-oh May 3, 2024 15:40
@jeremyary jeremyary changed the title chore: Bumping CI to test new cloud creds, do not merge chore: Update CI-related AWS settings due to cred swap & global namespace issues May 3, 2024
@jeremyary jeremyary added do-not-merge/work-in-progress ok-to-test and removed do-not-merge/work-in-progress ok-to-test labels May 3, 2024
@tokoko tokoko mentioned this pull request May 6, 2024
feat: Adding get_online_features_async to feature store sdk #4172
Merged
@jeremyary
jeremyary force-pushed the bump-ci branch from 2d28af7 to 4a222d7 Compare May 7, 2024 11:11
@jeremyary
chore: Update S3 CI bucket to avoid global namespace issues
ae7759d 
Signed-off-by: Jeremy Ary <[email protected]>
@jeremyary
jeremyary force-pushed the bump-ci branch from 4a222d7 to ae7759d Compare May 7, 2024 11:19
franciscojavierarceo
franciscojavierarceo approved these changes May 7, 2024
View reviewed changes

@franciscojavierarceo franciscojavierarceo left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@franciscojavierarceo
franciscojavierarceo merged commit 67bea4c into feast-dev:master May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jeremyary @franciscojavierarceo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.