GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ci: Add missing CI for feast-operator image builds by tchughesiv · Pull Request #4184 · feast-dev/feast

Conversation

@tchughesiv

@tchughesiv tchughesiv commented May 7, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Missing CI related to #4145

This change will require that the following image repos are created (if they don't already exist) -

gcr.io/kf-feast/feast-operator
gcr.io/kf-feast/feature-server

Which issue(s) this PR fixes:

#4144

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tchughesiv tchughesiv changed the title add missing CI for feast-operator image builds fix: add missing CI for feast-operator image builds May 7, 2024
@tchughesiv tchughesiv changed the title fix: add missing CI for feast-operator image builds fix: Add missing CI for feast-operator image builds May 7, 2024
@tchughesiv tchughesiv changed the title fix: Add missing CI for feast-operator image builds test: Add missing CI for feast-operator image builds May 7, 2024
@tchughesiv tchughesiv changed the title test: Add missing CI for feast-operator image builds ci: Add missing CI for feast-operator image builds May 7, 2024
@jeremyary jeremyary added the ok-to-test label May 8, 2024
@tchughesiv

tchughesiv commented May 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@woop is this something you can help with? the creation of those repos that is.
or, maybe increased perms for @franciscojavierarceo or @jeremyary so they can handle it?

jeremyary reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@woop

woop commented May 13, 2024

Copy link
Copy Markdown
Member

Checking this out right now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@woop

woop commented May 13, 2024

Copy link
Copy Markdown
Member

Just to confirm, is there a reason we'd use kf-feast on GCR instead of dockerhub? Also, @franciscojavierarceo can you confirm what access you have already?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tchughesiv

tchughesiv commented May 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@woop its used in .github/workflows/master_only.yml, which is named "integration-tests-and-build". it appears to run upon PR merge into the master branch and is a way a ensure image builds/pushes are working prior to release.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@franciscojavierarceo

franciscojavierarceo commented May 17, 2024

Copy link
Copy Markdown
Member

I have access to Dockerhub but not gcr

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@woop

woop commented May 19, 2024

Copy link
Copy Markdown
Member

Hey @franciscojavierarceo you should have GCR access now if you check your GCP console.

franciscojavierarceo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tchughesiv
tchughesiv force-pushed the feast-operator-ci-dev branch 3 times, most recently from 070c8d4 to 1719d65 Compare June 19, 2024 14:36
@tchughesiv

tchughesiv commented Jun 19, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@franciscojavierarceo @woop were these repos ever added? should we revisit this? it may help us troubleshoot some of the release build issues we've been facing. don't forget to add write perms for the gh actions robot account.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@franciscojavierarceo

franciscojavierarceo commented Jul 22, 2024

Copy link
Copy Markdown
Member

Sorry been out of the loop on this one @tchughesiv does this still need review or action from me?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dmartinol
dmartinol approved these changes Oct 29, 2024
View reviewed changes
@dmartinol
dmartinol self-requested a review October 29, 2024 14:47
@franciscojavierarceo

franciscojavierarceo commented Dec 23, 2024

Copy link
Copy Markdown
Member

@dmartinol looks like you need to fix some conflicts first

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tchughesiv
tchughesiv force-pushed the feast-operator-ci-dev branch from 1719d65 to 894d280 Compare December 29, 2024 17:07
@tchughesiv
add feast-operator builds to CI
1f3c60a
Signed-off-by: Tommy Hughes <[email protected]>
@tchughesiv
tchughesiv force-pushed the feast-operator-ci-dev branch from 6b84a1a to 1f3c60a Compare December 29, 2024 17:10
@tchughesiv

tchughesiv commented Dec 29, 2024

Copy link
Copy Markdown
Contributor Author

@franciscojavierarceo fixed...
but as a reminder, this PR shouldn't be merged until the repos in the description are created and provided push access to the workflow robot account.

franciscojavierarceo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@franciscojavierarceo

franciscojavierarceo commented Jan 1, 2025

Copy link
Copy Markdown
Member

@tchughesiv so the robot should have access. The gcr.io/kf-feast artifact registry already exits so I believe once we try to push the images it should create the artifact/image.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tchughesiv

tchughesiv commented Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

@franciscojavierarceo i guess it's worth a shot, but my expectation is that those new repos will have to exist first. especially because this registry has been deprecated and there's a migration guide.
https://cloud.google.com/artifact-registry/docs/transition/auto-migrate-gcr-ar

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

franciscojavierarceo
franciscojavierarceo approved these changes Jan 9, 2025
View reviewed changes

@franciscojavierarceo franciscojavierarceo left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's give this a try

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@franciscojavierarceo
franciscojavierarceo merged commit e983882 into feast-dev:master Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes
@dmartinol dmartinol Awaiting requested review from dmartinol

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tchughesiv @woop @franciscojavierarceo @dmartinol @jeremyary
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.