GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Adding write capabability to online store to on demand feature … by franciscojavierarceo · Pull Request #4418 · feast-dev/feast

Conversation

@franciscojavierarceo

@franciscojavierarceo franciscojavierarceo commented Aug 17, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

…views

What this PR does / why we need it:

Which issue(s) this PR fixes:

Misc

#4376

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@franciscojavierarceo franciscojavierarceo mentioned this pull request Sep 6, 2024
RequestSource can not be used with write_to_online_store #4493
Closed
@franciscojavierarceo
franciscojavierarceo force-pushed the persistent-odfvs branch 2 times, most recently from a10b3de to 7dcebcb Compare September 24, 2024 03:56
franciscojavierarceo
franciscojavierarceo commented Sep 24, 2024
View reviewed changes
Comment thread sdk/python/feast/infra/online_stores/sqlite.py Outdated

conn.execute(
f"""INSERT OR IGNORE INTO {table_name}
# try:

@franciscojavierarceo franciscojavierarceo Sep 24, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this once testing is done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@franciscojavierarceo
franciscojavierarceo force-pushed the persistent-odfvs branch 3 times, most recently from 9c90790 to 272b0f2 Compare September 25, 2024 03:38
franciscojavierarceo added 23 commits September 29, 2024 15:06
@franciscojavierarceo
merged changes
d03a895 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
saving progress
e0f42c6 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
merged changes to odfv
856cea2 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
linted
f6a7133 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
adding the test needed to show the expected behavior
fe387fc 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
updated test case
646a124 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
saving progress
b345e7e 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
merging
16e68f0 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
merged
24c4ae2 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
merged
3d21881 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
merging
7afaa84 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
adding the entity keys for now to do retrieval
436478a 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
adding entity to odfv
c78aead 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
checking in progress...getting closer
fbebc63 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
may have to revert some of this...looks like the challenge is getting…
5b3e2f5 
… the entities correct when storing writes. just checking in progress

Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
moving things around to make it easier to debug
7879e21 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
debugging
72caa15 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
merged
6d23889 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
merging
b76bf4e 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
Rebasing and merging changes from other PR
3cf0369 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
Merging changes continued
3a6dfc4 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
update the _make_inference to include odfvs with writes in the update…
1c37e54 
… map

Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
have the table being written now...the create table happens in the Sq…
2f9546f 
…liteOnlineStore.update() method

Signed-off-by: Francisco Javier Arceo <[email protected]>
franciscojavierarceo added 22 commits September 29, 2024 15:06
@franciscojavierarceo
checking in progress
c46e157 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
adding logs
580b77f 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
updating permissions
815a352 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
going to error out on purpose
2eda92c 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
adding unit test and merging changes
e326e9b 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
almost got everything working and type validation behaving
a54b5f8 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
cleaned up and have tests behaving
029c9cf 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
adding print
e2c6b35 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
removing print
adf147f 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
checking in progress
d34db1d 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
updating test
731bacb 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
adding test
8479296 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
linted and updated
3068c3b 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
removed print
238dc29 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
updated tests to test actual behavior
06315b9 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
checking in progress
05efa37 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
changing typo
8c559c8 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
updating test
8b8aa16 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
testing changes
4562a23 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
checking to see if thing still working
14f837d 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
removed print
082a860 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
undo change for odfv file
1d52d29 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
franciscojavierarceo force-pushed the persistent-odfvs branch from cc08644 to 1d52d29 Compare September 30, 2024 02:28
@franciscojavierarceo franciscojavierarceo closed this Oct 6, 2024
@franciscojavierarceo

franciscojavierarceo commented Oct 6, 2024

Copy link
Copy Markdown
Member Author

Moved to #4585
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@franciscojavierarceo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.