GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||
GeezerVison is showing github.com — fix: Added Apply/Get/List/Delete methods to project_metadata to BaseRegistry by EXPEbdodla · Pull Request #4441 · feast-dev/feast Conversation
|
| raise NotImplementedError | ||
|
|
||
| @abstractmethod | ||
| def apply_project_metadata( |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make more sense for this to also accept ProjectMetadata object as an input similar to other registry resources? I know the object doesn't hold much information right now, but if we plan for it to be "updatable", an update should happen through this method, right?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I was not envisioning this as a updatable. At this point its create only. Fields we have for this are UUID and LastUpdateTimestamp. UUID should be constant. LastUpdateTimestamp should be update when any changes happen to any objects associated to the project.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This probably means we will have to treat Another point... if we treat |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Signed-off-by: Bhargav Dodla <[email protected]>
… and using default string Signed-off-by: Bhargav Dodla <[email protected]>
Signed-off-by: Bhargav Dodla <[email protected]>
There was an error while loading. Please reload this page.
@tokoko You are right. We can introduce the Project object with spec and metadata. We can use the Project and fade out ProjectMetadata. Should I proceed with changing the PR accordingly? And I always saw Project as a parent entity for all the FEAST Objects. Having a Separate Project object will also help us to load or preserve the feature_store.yaml associated to the project as we progress further. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
We won't treat this as an object that users define in Feature Definitions. We can populate project name from feature_store.yaml. At this point, I'm not aware of any use cases for this. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
yup, that's what I think as well. A lot of rbac revolves around tagging, so it makes sense to make it possible to tag projects and consequently we will have to let users update those tags. Maybe we can make it so that users are able to define @franciscojavierarceo @HaoXuAI Any thoughts/objections about introducing |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Agreee, while developing the registry_server we'll also need to assert the required permissions. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
No objection. Can we have multiple projects per repo where different project use different online/offline store setup? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
@HaoXuAI We are discussing about the multiple Projects in the issue: #4199. Project object can help us enable multiple projects per repo. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@EXPEbdodla this is no longer relevant, right? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Is this PR still relevant? Thanks for doing this @EXPEbdodla and sorry for the complications here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Not relevant. I'll close it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.