GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: Explicit protobuf build version; consistent build/setup deps by cburroughs · Pull Request #4472 · feast-dev/feast

Conversation

@cburroughs

@cburroughs cburroughs commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

Right now if one downloads feast-0.40.1-py2.py3-none-any.whl from PyPi it contains:

$ grep 'Protobuf Python Version' feast/protos/feast/registry/RegistryServer_pb2.py

Which is outside

$ grep 'protobuf<' feast-0.40.1.dist-info/METADATA
Requires-Dist: protobuf<5.0.0,>=4.24.0

Leading to runtime errors (#4437). This was mitigated by #4438. This change tightens this up further by:

  • Deleting the Makefile command that was trying to do this unsuccessfully.
  • Aligns the setup/build requirements
  • Sets the version of protobuf to match the minimum of the range. There is no guarantee that protos generated by 4.X will work with 4.(X-1).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cburroughs
build: explicit protobuf build version; consistent build/setup deps
2aa12ea 
Right now if one downloads `feast-0.40.1-py2.py3-none-any.whl` from
PyPi it contains:
```
$ grep 'Protobuf Python Version' feast/protos/feast/registry/RegistryServer_pb2.py
```
Which is outside
```
$ grep 'protobuf<' feast-0.40.1.dist-info/METADATA
Requires-Dist: protobuf<5.0.0,>=4.24.0
```
Leading to runtime errors (feast-dev#4437).  This was mitigated by feast-dev#4438.  This
change tightens this up further by:
 * Deleting the Makefile command that was trying to do this
 unsuccessfully.
 * Aligns the setup/build requirements
 * Sets the version of protobuf to match the *minimum* of the range.
 There is no guarantee that protos generated by `4.X` will work with `4.(X-1)`.

Signed-off-by: Chris Burroughs <[email protected]>
@cburroughs cburroughs changed the title build: explicit protobuf build version; consistent build/setup deps build: Explicit protobuf build version; consistent build/setup deps Aug 30, 2024
tokoko
tokoko reviewed Sep 1, 2024
View reviewed changes
Comment thread environment-setup.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tokoko tokoko added the ok-to-test label Sep 3, 2024
tokoko
tokoko approved these changes Sep 3, 2024
View reviewed changes
@tokoko
tokoko merged commit 8fef194 into feast-dev:master Sep 3, 2024
@zabarn zabarn mentioned this pull request Sep 4, 2024
build: Explicit protobuf build version; consistent build/setup deps ExpediaGroup/feast#136
Draft
@cburroughs cburroughs mentioned this pull request Jan 28, 2025
fix: Removed protobuf as a required dependency #4535
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tokoko tokoko tokoko approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cburroughs @tokoko
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.