GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Update README.md by franciscojavierarceo · Pull Request #4893 · feast-dev/feast

Conversation

@franciscojavierarceo

@franciscojavierarceo franciscojavierarceo commented Jan 4, 2025

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Misc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@franciscojavierarceo
Update README.md
8f2a529
@franciscojavierarceo franciscojavierarceo added the ok-to-test label Jan 4, 2025
redhatHameed
redhatHameed approved these changes Jan 6, 2025
View reviewed changes
@franciscojavierarceo

franciscojavierarceo commented Jan 6, 2025

Copy link
Copy Markdown
Member Author

@redhatHameed can you take a look at this error? I'm trying to figure out what's causing this issue. I changed the workflow in #4891 and maybe that's causing the issue?
redhatHameed reacted with thumbs up emoji redhatHameed reacted with eyes emoji
All reactions
  • 👍 1 reaction
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@franciscojavierarceo

franciscojavierarceo commented Jan 6, 2025

Copy link
Copy Markdown
Member Author

will try reverting: #4900
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@redhatHameed

redhatHameed commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

@redhatHameed can you take a look at this error? I'm trying to figure out what's causing this issue. I changed the workflow in #4891 and maybe that's causing the issue?

is the docker-compose binary part of workflow or installed ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@franciscojavierarceo

franciscojavierarceo commented Jan 6, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@redhatHameed it's dynamically fetched and installed.

     wget https://github.com/milvus-io/milvus/releases/download/v2.5.1/milvus-standalone-docker-compose.yml -O docker-compose.yml
     docker compose up -d
redhatHameed reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lokeshrangineni

lokeshrangineni commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

I wonder why is this PR triggering the integration tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lokeshrangineni

lokeshrangineni commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

I wonder why is this PR triggering the integration tests.

Seems like branch is not redbased to pull latest changes related to fixing the integration test changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@franciscojavierarceo

franciscojavierarceo commented Jan 9, 2025

Copy link
Copy Markdown
Member Author

@lokeshrangineni I used this repo to test that the pr_integration_teste.yaml was the root cause of an error. I'll close this now.
lokeshrangineni reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@franciscojavierarceo franciscojavierarceo closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@redhatHameed redhatHameed redhatHameed approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@franciscojavierarceo @redhatHameed @lokeshrangineni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.