GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Remove grpcurl dependency (v0.43-branch) by tchughesiv · Pull Request #4976 · feast-dev/feast

Conversation

@tchughesiv

@tchughesiv tchughesiv commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Removing this grpcurl image dependency as it's unnecessary and, if possible, we should avoid third party deps.

Which issue(s) this PR fixes:

Relates to #4972

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tchughesiv
tchughesiv requested a review from a team as a code owner January 28, 2025 15:56
@tchughesiv tchughesiv added the ok-to-test label Jan 28, 2025
lokeshrangineni
lokeshrangineni approved these changes Jan 28, 2025
View reviewed changes
redhatHameed
redhatHameed approved these changes Jan 28, 2025
View reviewed changes
@tchughesiv
remove grpcurl dependency
bc8e35f 
Signed-off-by: Tommy Hughes <[email protected]>
@tchughesiv
tchughesiv force-pushed the grpcurl43 branch from d92c2d7 to bc8e35f Compare January 28, 2025 16:32
@tchughesiv
tchughesiv merged commit 089ec93 into feast-dev:v0.43-branch Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lokeshrangineni lokeshrangineni lokeshrangineni approved these changes
@redhatHameed redhatHameed redhatHameed approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tchughesiv @lokeshrangineni @redhatHameed
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.