GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Changed Env Vars for e2e tests (#4975) by tchughesiv · Pull Request #4990 · feast-dev/feast

Conversation

@tchughesiv

@tchughesiv tchughesiv commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

  • Changed Env Vars for e2e tests

  • Made e2e changes following review

What this PR does / why we need it:

cherry-pick of #4975

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tmihalac @tchughesiv
fix: Changed Env Vars for e2e tests (feast-dev#4975)
400fa63 
* Changed Env Vars for e2e tests

Signed-off-by: Theodor Mihalache <[email protected]>

* Made e2e changes following review

Signed-off-by: Theodor Mihalache <[email protected]>

---------

Signed-off-by: Theodor Mihalache <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
@tchughesiv tchughesiv added the ok-to-test label Jan 30, 2025
@tchughesiv
tchughesiv requested a review from a team as a code owner January 30, 2025 17:13
redhatHameed
redhatHameed approved these changes Jan 30, 2025
View reviewed changes
@tchughesiv
tchughesiv merged commit 5d6dae3 into feast-dev:v0.43-branch Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@redhatHameed redhatHameed redhatHameed approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tchughesiv @redhatHameed @tmihalac
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.