GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Adding docling to feast as add on by franciscojavierarceo · Pull Request #5065 · feast-dev/feast

Conversation

@franciscojavierarceo

@franciscojavierarceo franciscojavierarceo commented Feb 18, 2025

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Adding docling to feast as add on

Which issue(s) this PR fixes:

Misc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@franciscojavierarceo
franciscojavierarceo requested a review from a team as a code owner February 18, 2025 01:09
dmartinol
dmartinol reviewed Feb 18, 2025
View reviewed changes
Comment thread setup.py

MILVUS_REQUIRED = ["pymilvus"]

RAG_REQUIRED = ["docling"]

@dmartinol dmartinol Feb 18, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unversioned?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@franciscojavierarceo franciscojavierarceo Feb 18, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to figure out which version was most appropriate unbounded but this uncovered the broader issue of us having to move to pyproject.toml over the setup.py so we'll have to work on that first.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dmartinol reacted with thumbs up emoji dmartinol reacted with confused emoji
All reactions
  • 👍 1 reaction
  • 😕 1 reaction

@franciscojavierarceo franciscojavierarceo Feb 18, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it looks like it's being handled here! #5067

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@franciscojavierarceo
feat: Adding docling to feast as add on
927c2cf 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
franciscojavierarceo force-pushed the docling branch from 016d107 to 927c2cf Compare February 19, 2025 01:18
@franciscojavierarceo
updated
8375ead 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@ntkathole ntkathole mentioned this pull request Feb 24, 2025
Add Docling to Feast #5037
Closed
@franciscojavierarceo franciscojavierarceo closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmartinol dmartinol dmartinol left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@franciscojavierarceo @dmartinol
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.