GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Update uv version to latest by ntkathole · Pull Request #5086 · feast-dev/feast

Conversation

@ntkathole

@ntkathole ntkathole commented Feb 25, 2025

Copy link
Copy Markdown
Member

What this PR does / why we need it:

This PR updates the uv version to latest. Using old version of uv, it was removing required dependencies while compiling the pip.

New version is ensuring more accurate resolution of package versions and requirements, also, prevents unnecessary removals by better handling version conflicts and sub-dependencies.

Which issue(s) this PR fixes:

This was blocking CI to pass while trying to add new add on.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ntkathole
ntkathole requested a review from a team as a code owner February 25, 2025 06:57
@ntkathole
ntkathole force-pushed the update_uv branch 3 times, most recently from 992abe6 to 1af4a70 Compare February 25, 2025 09:48
ntkathole
ntkathole commented Feb 25, 2025
View reviewed changes
Comment thread pyproject.toml
]
ge = ["great_expectations>=0.15.41"]
go = ["cffi~=1.15.0"]
ge = ["great_expectations>=0.15.41,<1"]

@ntkathole ntkathole Feb 25, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5087

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
franciscojavierarceo reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@ntkathole
ntkathole force-pushed the update_uv branch from 1af4a70 to dca9af4 Compare February 25, 2025 09:56
ntkathole
ntkathole commented Feb 25, 2025
View reviewed changes
Comment thread sdk/python/tests/doctest/test_all.py
temp_module = importlib.import_module(full_name)
if is_pkg:
next_packages.append(temp_module)
if "ikv" not in full_name and "milvus" not in full_name:

@ntkathole ntkathole Feb 25, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5088

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ntkathole
ntkathole force-pushed the update_uv branch from dca9af4 to 115c51b Compare February 25, 2025 10:00
@ntkathole ntkathole mentioned this pull request Feb 25, 2025
Add Docling to Feast #5037
Closed
@ntkathole
chore: Update uv version to latest
c884ae5 
Signed-off-by: ntkathole <[email protected]>
@ntkathole
ntkathole force-pushed the update_uv branch from 115c51b to c884ae5 Compare February 25, 2025 10:11
ntkathole
ntkathole commented Feb 25, 2025
View reviewed changes
Comment thread pyproject.toml
ge = ["great_expectations>=0.15.41"]
go = ["cffi~=1.15.0"]
ge = ["great_expectations>=0.15.41,<1"]
go = ["cffi>=1.15.0"]

@ntkathole ntkathole Feb 25, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ikv needs cffi>=1.16.0
https://github.com/inlinedio/ikv-store/blob/master/ikv-python-client/pyproject.toml#L29

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
franciscojavierarceo
franciscojavierarceo approved these changes Feb 25, 2025
View reviewed changes
@franciscojavierarceo franciscojavierarceo added the ok-to-test label Feb 25, 2025
@franciscojavierarceo
franciscojavierarceo enabled auto-merge (squash) February 25, 2025 11:12
@franciscojavierarceo
franciscojavierarceo merged commit e25ca4f into feast-dev:master Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ntkathole @franciscojavierarceo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.