GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: ignore ipynb files during apply by gabrielaugz · Pull Request #5177 · feast-dev/feast

Conversation

@gabrielaugz

@gabrielaugz gabrielaugz commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Ignore Jupyter Notebook Files extensions when using feast apply

Which issue(s) this PR fixes:

Fixes #5145

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gabrielaugz
feat: ignore ipynb files during apply
584d1a5
@gabrielaugz
gabrielaugz requested a review from a team as a code owner March 21, 2025 14:27
redhatHameed
redhatHameed reviewed Mar 21, 2025
View reviewed changes
Comment thread sdk/python/feast/repo_operations.py
p.resolve()
for p in repo_root.glob("**/*.py")
if p.is_file() and "__init__.py" != p.name
and not p.name.endswith(".ipynb") # Ignore Jupyter Notebook files during feast apply

@redhatHameed redhatHameed Mar 21, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also if you can add .ipynb_checkpoints to ignore

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gabrielaugz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
franciscojavierarceo
franciscojavierarceo reviewed Mar 21, 2025
View reviewed changes
Comment thread sdk/python/feast/repo_operations.py
p.resolve()
for p in repo_root.glob("**/*.py")
if p.is_file() and "__init__.py" != p.name
and not p.name.endswith(".ipynb") # Ignore Jupyter Notebook files during feast apply

@franciscojavierarceo franciscojavierarceo Mar 21, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this a list of files we ignore and add .ipynb to it?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@franciscojavierarceo franciscojavierarceo Mar 21, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, I see .ipynb_checkpoints in the ignore_paths but I have experienced this issue locally very frequently.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@redhatHameed redhatHameed Mar 21, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me too, I just used to do find . -name ".ipynb_checkpoints" -type d -exec rm -rf {} +

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@franciscojavierarceo franciscojavierarceo Mar 21, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i do something similar

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@stale

stale Bot commented Jul 19, 2025

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ntkathole ntkathole mentioned this pull request Mar 26, 2026
fix: Ignore ipynb files during apply #6151
Merged
5 of 7 tasks
@ntkathole

ntkathole commented Mar 27, 2026

Copy link
Copy Markdown
Member

closing in favor of #6151
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ntkathole ntkathole closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo left review comments
@redhatHameed redhatHameed redhatHameed left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feast apply should ignore Jupyter Notebooks

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gabrielaugz @ntkathole @franciscojavierarceo @redhatHameed
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.